Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use retrieveRequestParams where possible #1818

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

kangmingtay
Copy link
Member

What kind of change does this PR introduce?

  • Move the reading the requestBody into the captcha middleware, which is in the api package so it can use retrieveRequestParams
  • Use retrieveRequestParams in the admin delete route

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Add any other context or screenshots.

@kangmingtay kangmingtay requested a review from a team as a code owner October 28, 2024 07:22
@kangmingtay kangmingtay force-pushed the km/ref-retrieve-request-params branch from 956d933 to 834d03c Compare October 28, 2024 07:38
@coveralls
Copy link

coveralls commented Oct 28, 2024

Pull Request Test Coverage Report for Build 11550768364

Details

  • 12 of 15 (80.0%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.005%) to 57.16%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/admin.go 6 7 85.71%
internal/api/middleware.go 4 6 66.67%
Files with Coverage Reduction New Missed Lines %
internal/api/admin.go 1 65.81%
internal/api/middleware.go 2 80.52%
Totals Coverage Status
Change from base Build 11548689337: -0.005%
Covered Lines: 9564
Relevant Lines: 16732

💛 - Coveralls

internal/api/admin.go Outdated Show resolved Hide resolved
Copy link
Contributor

@J0 J0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, great work

@kangmingtay kangmingtay force-pushed the km/ref-retrieve-request-params branch from 28b2682 to 05c4e2e Compare October 28, 2024 09:11
@kangmingtay kangmingtay merged commit 3b03472 into master Oct 28, 2024
2 checks passed
@kangmingtay kangmingtay deleted the km/ref-retrieve-request-params branch October 28, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants