Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CA018] added like functionality [SD,SM] #72

Merged
merged 18 commits into from
May 19, 2021
Merged

[CA018] added like functionality [SD,SM] #72

merged 18 commits into from
May 19, 2021

Conversation

ManuelSchoellauf
Copy link
Contributor

Merged current develop with like functionality.

ManuelSchoellauf and others added 17 commits May 5, 2021 10:41
@ManuelSchoellauf
CRA-FE-17 like functionality implemented [GD,SM]
58594b6
@ManuelSchoellauf
CRA-FE-17 like with temporary picture [GD,SM]
6178d70
@ManuelSchoellauf
CRA-FE-17 heart_btn added to detail page [GD,SM]
383b06c
test
fe26bc6
crop image for like button
0edff23
change background to transparent
764dd93
missing set local variable
64754ae
@ManuelSchoellauf
CRA-FE-17 unlike call added to server_api [GD,SM]
ffadf7e
[CRA-FE-17] add unlike function [GD,SM]
1381db0
@ManuelSchoellauf
CRA-FE-17 fixed like button [GD,SM]
5befacc
Merge branch 'like' of https://github.com/ManuelSchoellauf/Team_03 in…
0f5f7a9 
…to like
[CRA-FE-17] merge [GD,SM]
f82ef3f
@ManuelSchoellauf
CRA-FE-17 fully implemented like functionality [GD,SM]
b584061
@ManuelSchoellauf
CRA-FE-17 minor bugfix [GD,SM]
020a30d
@ManuelSchoellauf
Merge branch 'develop' of https://github.com/sw21-tug/Team_03 into like
ab49908
@ManuelSchoellauf
Merge branch 'develop' of https://github.com/sw21-tug/Team_03 into like
488e2b0
@ManuelSchoellauf
Merge branch 'develop' of https://github.com/sw21-tug/Team_03 into like
b4b4586
@ManuelSchoellauf ManuelSchoellauf added the devtask Tasks for the developers label May 19, 2021
@ManuelSchoellauf ManuelSchoellauf requested a review from xsoliah May 19, 2021 07:46
This was linked to issues May 19, 2021
[CR018] Like recipes #18
Closed
[DEV:FE17] add like function #57
Closed
xsoliah
xsoliah requested changes May 19, 2021
View reviewed changes
Copy link
Contributor

@xsoliah xsoliah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

userId is global, you don't need to read it from shared preferences, right?

@ManuelSchoellauf ManuelSchoellauf requested a review from xsoliah May 19, 2021 08:06
@ManuelSchoellauf
Copy link
Contributor Author

Changed cocktailDetailActivity() so that it uses the global user_id

xsoliah
xsoliah approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@xsoliah xsoliah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

schaut gut aus

@olliwho olliwho merged commit 2fdede6 into sw21-tug:develop May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xsoliah xsoliah xsoliah approved these changes

Assignees

@ManuelSchoellauf ManuelSchoellauf

@dansch26 dansch26

@dschrey dschrey

Labels
devtask Tasks for the developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DEV:FE17] add like function [CR018] Like recipes
5 participants
@ManuelSchoellauf @xsoliah @olliwho @dansch26 @dschrey