Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#0: fix bug in createqkv #17452

Merged
merged 1 commit into from
Jan 31, 2025
Merged

#0: fix bug in createqkv #17452

merged 1 commit into from
Jan 31, 2025

Conversation

kpaigwar
Copy link
Contributor

@kpaigwar kpaigwar commented Jan 31, 2025

Desciption

This fixes the failure for llama3/test/test_llama_attention.py in CI introduced by following PR for slicing support in ttnn.nlp_create_QKV_heads_decode when one of the optional tensor argument buffer is read even though its value doesn't exist.

Error

https://github.com/tenstorrent/tt-metal/actions/runs/13076612535/job/36490477945

ttnn::tensor::buffer(): Expected Tensor with DeviceStorage, got StorageType::OWNED
backtrace:
 --- void tt::assert::tt_throw_impl<fmt::v11::basic_format_string<char, tt::tt_metal::StorageType const&>, tt::tt_metal::StorageType>(char const*, int, char const*, char const*, fmt::v11::basic_format_string<char, tt::tt_metal::StorageType const&> const&, tt::tt_metal::StorageType const&)
 --- /home/ubuntu/actions-runner/_work/tt-metal/tt-metal/ttnn/ttnn/_ttnn.so(+0x5123de) [0x7f21d2be33de]
 --- ttnn::operations::experimental::transformer::multi_core_nlp_create_qkv_heads_decode_sharded_input(tt::tt_metal::Tensor const&, unsigned int, unsigned int, unsigned int, bool, std::__1::optional<tt::tt_metal::Tensor const> const&, std::__1::optional<unsigned int const>, std::__1::vector<tt::tt_metal::Tensor, std::__1::allocator<tt::tt_metal::Tensor>>&, tt::umd::xy_pair)

@kpaigwar kpaigwar marked this pull request as ready for review January 31, 2025 20:21
@kpaigwar kpaigwar requested a review from a team as a code owner January 31, 2025 20:21
@williamlyTT williamlyTT merged commit c7825a1 into main Jan 31, 2025
9 checks passed
@williamlyTT williamlyTT deleted the kpaigwar/fix-createqkv branch January 31, 2025 20:23
nikileshx pushed a commit to nikileshx/tt-metal that referenced this pull request Feb 3, 2025
### Ticket
Link to Github Issue

### Problem description
Provide context for the problem.

### What's changed
Describe the approach used to solve the problem.
Summarize the changes made and its impact.

### Checklist
- [ ] Post commit CI passes
- [ ] Blackhole Post commit (if applicable)
- [ ] Model regression CI testing passes (if applicable)
- [ ] Device performance regression CI testing passes (if applicable)
- [ ] **(For models and ops writers)** Full [new
models](https://github.com/tenstorrent/tt-metal/actions/workflows/full-new-models-suite.yaml)
tests passes
- [ ] New/Existing tests provide coverage for changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants