Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#0: fix bug in createqkv #17452

Merged
merged 1 commit into from
Jan 31, 2025
Merged

#0: fix bug in createqkv #17452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...former/nlp_create_qkv_heads_decode/device/nlp_create_qkv_heads_decode_program_factory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,9 @@ operation::ProgramWithCallbacks multi_core_nlp_create_qkv_heads_decode_sharded_i
process_qv, // read and write q and v heads
process_k, // read and write k heads
batch_offset.has_value() ? 1 : 0, // use_batch_offset
batch_offset->buffer()->buffer_type() == tt_metal::BufferType::DRAM ? (uint32_t)1 : (uint32_t)0,
batch_offset.has_value() && batch_offset->buffer()->buffer_type() == tt_metal::BufferType::DRAM
? (uint32_t)1
: (uint32_t)0,
batch_offset_index_stick_size,
batch_offset_cb_index_reader};
auto q_reader_kernel_id = tt_metal::CreateKernel(
Expand Down
Loading