Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poset Refactor #293

Merged
merged 14 commits into from
Nov 30, 2023
Merged

Poset Refactor #293

merged 14 commits into from
Nov 30, 2023

Conversation

TOTBWF
Copy link
Collaborator

@TOTBWF TOTBWF commented Nov 29, 2023

Description

This PR bundles Poset and monotone maps. This is the first stage of the poset refactor: none of the changes around frames/lattices were made yet!.

Todo:
[ ] Update Prose

@TOTBWF TOTBWF requested a review from plt-amy November 29, 2023 05:52
src/Order/Base.lagda.md Outdated Show resolved Hide resolved
src/Order/Base.lagda.md Outdated Show resolved Hide resolved
src/Order/Base.lagda.md Outdated Show resolved Hide resolved
src/Order/Base.lagda.md Outdated Show resolved Hide resolved
Copy link

Rendered preview

@TOTBWF TOTBWF marked this pull request as ready for review November 29, 2023 19:56
@plt-amy plt-amy requested a review from favonia November 30, 2023 14:15
src/Order/Base.lagda.md Outdated Show resolved Hide resolved
src/Order/Base.lagda.md Outdated Show resolved Hide resolved
@favonia
Copy link
Contributor

favonia commented Nov 30, 2023

Question: why do we want opaque when, as far as I can tell, no one will want to unfold Ob-is-set?

@plt-amy
Copy link
Member

plt-amy commented Nov 30, 2023

Good point, from a "say what you mean" perspective those could be abstract; all that it matters is that it doesn't accidentally reduce in someone's face, since it's a pretty nasty term.

@favonia
Copy link
Contributor

favonia commented Nov 30, 2023

@plt-amy Yes I do mean using abstract, the "absolute" opaque. In fact I want to add abstract (and maybe irrelevance) to many definitions in 1lab...

@plt-amy plt-amy enabled auto-merge (squash) November 30, 2023 16:50
@plt-amy plt-amy merged commit 497ac8c into main Nov 30, 2023
5 checks passed
@plt-amy plt-amy deleted the poset-refactor branch November 30, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants