Mediatek: mt8196: add platform/core_config/build_config #9758

hailongfan-mtk · 2024-12-26T01:59:28Z

Add mediatek mt8196 platform/core_config/build_config drivers for auido development.

Add mt8196.toml to support sof-mt8196.ri binary build. Signed-off-by: hailong.fan <[email protected]>

sofci · 2024-12-26T02:00:22Z

Can one of the admins verify this patch?

reply test this please to run this test once

kv2019i

Not sure how this aligns with #9755 , but no showstoppers as far as I can tell. There's a bit of commented out code left here and there, but I'll leave this to @thesofproject/mediatek maintainers to check as this is all in MTK platform code.

kv2019i · 2024-12-27T11:35:01Z

src/platform/mt8196/lib/clk.c

+	}
+
+	//todo
+	//io_reg_update_bits(MTK_ADSPPLL_CON3, MTK_PLL_PWR_ON, MTK_PLL_PWR_ON);


Maybe clean this up, I guess these are now copied from platform to another as copies.

Maybe clean this up, I guess these are now copied from platform to another as copies.

Yes, updated, thanks.

kv2019i · 2024-12-27T11:40:10Z

SOFCI TEST

andyross · 2024-12-30T21:10:36Z

Not sure how this aligns with #9755

Parallel efforts. The intent is that this hardware ships with Zephyr at launch, but for now there are two trees for different bits of enablement.

lgirdwood · 2025-01-06T16:24:45Z

Not sure how this aligns with #9755

Parallel efforts. The intent is that this hardware ships with Zephyr at launch, but for now there are two trees for different bits of enablement.

Okay, how do you want to proceed - obviously xtos related code is being deprecated and removed.

Add xtensa headers for mediatek mt8196 platform. Signed-off-by: hailong.fan <[email protected]>

Add memory layout and register address for mediatek mt8196 [Cache] I-Cache: 64KB, 4-way Associativity D-Cache: 128KB, 4-way Associativity [Memory] Dram: ADSP can access DRAM shared with CPU L2TCM: 768KB ADSP SRAM POOL Signed-off-by: hailong.fan <[email protected]>

mt8196 plaform integrates a single-core HIFI5 DSP. The DSP does not have DVFS scenario. When the system is in an active state, the DSP clock is 800MHz(0.75v). When the system enters a low power scenario, the DSP is in WFI state, and the clock is 26MHz. The DSP core and DMA in DSP subsys both can access DRAM directly. Signed-off-by: hailong.fan <[email protected]>

lyakh · 2025-01-07T08:45:02Z

src/drivers/mediatek/mt8196/intc.c

+#ifdef CFG_CORE_OFF_SUPPORT
+#endif
+#ifdef CFG_TICKLESS_SUPPORT
+#endif


seem unneeded?

Yes, removed, thanks.

Add interrupt, timer and ipc driver for mt8196. Signed-off-by: hailong.fan <[email protected]>

Add default config for mt8196 platform. Signed-off-by: hailong.fan <[email protected]>

andyross · 2025-01-07T16:21:35Z

Okay, how do you want to proceed - obviously xtos related code is being deprecated and removed.

I'm entirely neutral on whether this gets merged separately. I think it's probably useful to have as a reference in the public tree, even if it gets deleted. But the Zephyr work is far enough along now that I really don't think there's much need to maintain two working versions. Ideally we all end up on the same page, and e.g. @hailongfan-mtk would be reviewing the Zephyr platform too.

Will come by with some notes here in a bit once I figure out the divergence with the internal tree (which is based on a somewhat older SOF)

lgirdwood · 2025-01-08T15:35:04Z

Okay, how do you want to proceed - obviously xtos related code is being deprecated and removed.

I'm entirely neutral on whether this gets merged separately. I think it's probably useful to have as a reference in the public tree, even if it gets deleted. But the Zephyr work is far enough along now that I really don't think there's much need to maintain two working versions. Ideally we all end up on the same page, and e.g. @hailongfan-mtk would be reviewing the Zephyr platform too.

Will come by with some notes here in a bit once I figure out the divergence with the internal tree (which is based on a somewhat older SOF)

ok, @hailongfan-mtk @andyross we can merge this now as a backup for the Zephyr work, and then deprecate/delete as the Zephyr support stabilzes ? Good for you guys ?

andyross

This looks incomplete? I don't see the integration for the AFE driver. Presumably this would boot, but would have no audio capability? (c.f. src/platform/mt81*/afe-platform.c and related files in the current tree) Is that coming in a separate PR?

andyross · 2025-01-08T16:27:40Z

src/platform/mt8196/platform.c

+	XTHAL_MPU_ENTRY(0x4e180000, 1, XTHAL_AR_NONE, XTHAL_MEM_DEVICE),		// unused
+	XTHAL_MPU_ENTRY(0x90000000, 1, XTHAL_AR_RWXrwx, XTHAL_MEM_WRITEBACK_NOALLOC),	// dram
+	XTHAL_MPU_ENTRY(0x90500000, 1, XTHAL_AR_RWXrwx, XTHAL_MEM_NON_CACHEABLE),	// dram
+	XTHAL_MPU_ENTRY(0x91100000, 1, XTHAL_AR_NONE, XTHAL_MEM_DEVICE),		// unused


FWIW I think this MPU setup is skewed vs. what is being used internally (there have been two recent changes I'm aware of, anyway). Can you be sure to synchronize the trees and validate this vs. the SOF main branch?

FWIW I think this MPU setup is skewed vs. what is being used internally (there have been two recent changes I'm aware of, anyway). Can you be sure to synchronize the trees and validate this vs. the SOF main branch?

The current MPU settings are correct and have been verified. Other changes (cache issues) will be submitted later.

andyross

But +1 as-is, no reason not to merge as long as the remaining bits are coming.

hailongfan-mtk · 2025-01-09T01:15:51Z

This looks incomplete? I don't see the integration for the AFE driver. Presumably this would boot, but would have no audio capability? (c.f. src/platform/mt81*/afe-platform.c and related files in the current tree) Is that coming in a separate PR?

Yes, this is only the DSP system part, the AFE part will be proposed in another PR.

hailongfan-mtk · 2025-01-09T01:59:47Z

Okay, how do you want to proceed - obviously xtos related code is being deprecated and removed.

I'm entirely neutral on whether this gets merged separately. I think it's probably useful to have as a reference in the public tree, even if it gets deleted. But the Zephyr work is far enough along now that I really don't think there's much need to maintain two working versions. Ideally we all end up on the same page, and e.g. @hailongfan-mtk would be reviewing the Zephyr platform too.
Will come by with some notes here in a bit once I figure out the divergence with the internal tree (which is based on a somewhat older SOF)

ok, @hailongfan-mtk @andyross we can merge this now as a backup for the Zephyr work, and then deprecate/delete as the Zephyr support stabilzes ? Good for you guys ?

ok, thanks a lot

lgirdwood · 2025-01-09T17:12:39Z

CI been hanging a long time - restart it.

lgirdwood · 2025-01-09T17:12:46Z

SOFCI TEST

kv2019i · 2025-01-10T14:16:54Z

@hailongfan-mtk The build is failing: https://github.com/thesofproject/sof/actions/runs/12648815920/job/35243903764?pr=9758

 CMake Error at CMakeLists.txt:39 (project):
  The CMAKE_C_COMPILER:

    xtensa-mt8196-elf-gcc

I think we've accepted platforms that cannot be compile tested with github flows, but these shouldn't be in the default platform list. If we merge this in current form, gcc-build-default-platforms will start failing for every pull request.

johnylin76 · 2025-01-13T06:35:38Z

scripts/xtensa-build-all.sh

@@ -10,7 +10,7 @@ set -e
 DEFAULT_PLATFORMS=(
    imx8m
    rn rmb vangogh
-    mt8186 mt8195 mt8188
+    mt8186 mt8195 mt8188 mt8196


@hailongfan-mtk please remove mt8196 from DEFAULT_PLATFORMS

Updated, thanks.

Add CMakefile for mediatek mt8196 platform to build. Signed-off-by: hailong.fan <[email protected]>

johnylin76 · 2025-01-14T05:41:18Z

CI now only has codestyle failures left. Should be good to go

lgirdwood · 2025-01-14T14:07:22Z

CI stalled - restart.

lgirdwood · 2025-01-14T14:07:29Z

SOFCI TEST

config: Add mt8196.toml

5cf015b

Add mt8196.toml to support sof-mt8196.ri binary build. Signed-off-by: hailong.fan <[email protected]>

hailongfan-mtk requested review from akloniex, lgirdwood, plbossart, mmaka1, lbetlej, dbaluta and kv2019i as code owners December 26, 2024 01:59

kv2019i approved these changes Dec 27, 2024

View reviewed changes

kv2019i mentioned this pull request Dec 27, 2024

src/platform: Add "mtk" Zephyr platform for MediaTek DSPs #9755

Merged

lgirdwood approved these changes Jan 6, 2025

View reviewed changes

hailongfan-mtk added 3 commits January 7, 2025 16:23

platform: mediatek: add xtensa headers for mt8196

b61bb36

Add xtensa headers for mediatek mt8196 platform. Signed-off-by: hailong.fan <[email protected]>

hailongfan-mtk force-pushed the main branch from ff2a236 to 4e8e4fb Compare January 7, 2025 08:40

lyakh reviewed Jan 7, 2025

View reviewed changes

hailongfan-mtk added 2 commits January 7, 2025 17:29

drivers: mediatek: Add drivers for mt8196

1253190

Add interrupt, timer and ipc driver for mt8196. Signed-off-by: hailong.fan <[email protected]>

config: Add default config for mt8196

62b3d90

Add default config for mt8196 platform. Signed-off-by: hailong.fan <[email protected]>

hailongfan-mtk force-pushed the main branch from bc189b5 to c202a66 Compare January 7, 2025 09:30

lyakh approved these changes Jan 8, 2025

View reviewed changes

andyross reviewed Jan 8, 2025

View reviewed changes

andyross approved these changes Jan 8, 2025

View reviewed changes

lgirdwood approved these changes Jan 8, 2025

View reviewed changes

johnylin76 self-requested a review January 10, 2025 13:06

johnylin76 approved these changes Jan 10, 2025

View reviewed changes

johnylin76 reviewed Jan 13, 2025

View reviewed changes

platform: Add build support for mediatek mt8196 platform

6c167ff

Add CMakefile for mediatek mt8196 platform to build. Signed-off-by: hailong.fan <[email protected]>

hailongfan-mtk force-pushed the main branch from 6e1d83b to 6c167ff Compare January 14, 2025 02:43

kv2019i merged commit 42e5c21 into thesofproject:main Jan 15, 2025
45 of 51 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mediatek: mt8196: add platform/core_config/build_config #9758

Mediatek: mt8196: add platform/core_config/build_config #9758

hailongfan-mtk commented Dec 26, 2024

sofci commented Dec 26, 2024

kv2019i left a comment

kv2019i Dec 27, 2024

hailongfan-mtk Jan 7, 2025

kv2019i commented Dec 27, 2024

andyross commented Dec 30, 2024

lgirdwood commented Jan 6, 2025

lyakh Jan 7, 2025

hailongfan-mtk Jan 7, 2025

andyross commented Jan 7, 2025

lgirdwood commented Jan 8, 2025

andyross left a comment

andyross Jan 8, 2025

hailongfan-mtk Jan 9, 2025

andyross left a comment

hailongfan-mtk commented Jan 9, 2025

hailongfan-mtk commented Jan 9, 2025 •

edited

Loading

lgirdwood commented Jan 9, 2025

lgirdwood commented Jan 9, 2025

kv2019i commented Jan 10, 2025

johnylin76 Jan 13, 2025

hailongfan-mtk Jan 14, 2025

johnylin76 commented Jan 14, 2025

lgirdwood commented Jan 14, 2025

lgirdwood commented Jan 14, 2025

Mediatek: mt8196: add platform/core_config/build_config #9758

Mediatek: mt8196: add platform/core_config/build_config #9758

Conversation

hailongfan-mtk commented Dec 26, 2024

sofci commented Dec 26, 2024

kv2019i left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kv2019i commented Dec 27, 2024

andyross commented Dec 30, 2024

lgirdwood commented Jan 6, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andyross commented Jan 7, 2025

lgirdwood commented Jan 8, 2025

andyross left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andyross left a comment

Choose a reason for hiding this comment

hailongfan-mtk commented Jan 9, 2025

hailongfan-mtk commented Jan 9, 2025 • edited Loading

lgirdwood commented Jan 9, 2025

lgirdwood commented Jan 9, 2025

kv2019i commented Jan 10, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

johnylin76 commented Jan 14, 2025

lgirdwood commented Jan 14, 2025

lgirdwood commented Jan 14, 2025

hailongfan-mtk commented Jan 9, 2025 •

edited

Loading