Update T coverage-pools dependency #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the `package.json` there are two different versions of `coverage-pools` used. This is done to allow using contracts from two different cov pool versions on the mainnet (needed for computations of the TVL-related fields) - one relates to KEEP token cov pool (<2.0.0) and one to to T token one (>=2.0.0). On the testnet environmet we currently don't have the T token cov pool deployed. The latest `goerli`- tagged version of the cov-pools package (`1.1.0-goerli.0`) contains KEEP-token related contracts. We want to stick to this version (we'll need to update it once we switch to Sepolia). For the `@threshold-network/coverage-pools` ideally we'd want to use a T token related pool, which if deployed for given environment, should be present in the latest `goerli`/`sepolia` package. If the T-related pool is not yet deployed for given environment, KEEP-related cov-pool contracts will be used in all TVL computations (which differs from the mainnet behavior, but is acceptable on the test env).
michalsmiarowski
requested changes
Nov 22, 2023
In commit 29853e3 we've removed `@keep-network/ecdsa, ` dependency, we no longer need to set the version of the corresponding package. We also no longer have a dependency to `@keep-network/tbtc-v2` and don't need to deploy new packages after changes of `@keep-network/tbtc-v2.ts`, so we don't need to set versions there as well.
michalinacienciala
force-pushed
the
update-t-cov-pools-dependency
branch
from
d11e9df to
ce23262
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
package.jsonthere are two different versions ofcoverage-poolsused. This is done to allow using contracts from two different cov pool versions on the mainnet (needed for computations of the TVL-related fields) - one relates to KEEP token cov pool (<2.0.0) and one to to T token one (>=2.0.0). On the testnet environmet we currently don't have the T token cov pool deployed. The latestgoerli- tagged version of the cov-pools package (1.1.0-goerli.0) contains KEEP-token related contracts. We want to stick to this version (we'll need to update it once we switch to Sepolia). For the@threshold-network/coverage-poolsideally we'd want to use a T token related pool, which if deployed for given environment, should be present in the latestgoerli/sepoliapackage. If the T-related pool is not yet deployed for given environment, KEEP-related cov-pool contracts will be used in all TVL computations (which differs from the mainnet behavior, but is acceptable on the test env).Ref: #613