Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update T coverage-pools dependency #639

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Update T coverage-pools dependency #639

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62db6ff
Update T coverage-pools dependency
michalinacienciala Oct 4, 2023
0acc7c1
Merge branch 'main' into update-t-cov-pools-dependency
michalsmiarowski Nov 22, 2023
ce23262
Remove obsolete actions
michalinacienciala Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions .github/workflows/reusable-build-and-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,9 +113,6 @@ jobs:
query: |
threshold-contracts-version = github.com/threshold-network/solidity-contracts#version
random-beacon-contracts-version = github.com/keep-network/keep-core/random-beacon#version
ecdsa-contracts-version = github.com/keep-network/keep-core/ecdsa#version
tbtc-v2-contracts-version = github.com/keep-network/tbtc-v2#version
tbtc-v2-ts-version = github.com/keep-network/tbtc-v2.ts#version

- name: Set packages versions
shell: bash
Expand All @@ -133,6 +130,23 @@ jobs:
# version of the `keep-core` package, because using `goerli` tag results
# in `expected manifest` error - probably caused by bug in Yarn:
# https://github.com/yarnpkg/yarn/issues/4731.

# In the `package.json` there are two different versions of
# `coverage-pools` used. This is done to allow using contracts from two
# different cov pool versions on the mainnet (needed for computations of
# the TVL-related fields) - one relates to KEEP token cov pool (<2.0.0)
# and one to to T token one (>=2.0.0).
# On the testnet environmet we currently don't have the T token cov pool
# deployed. The latest `goerli`- tagged version of the cov-pools package
# (`1.1.0-goerli.0`) contains KEEP-token related contracts. We want to
# stick to this version (we'll need to update it once we switch to
# Sepolia). For the `@threshold-network/coverage-pools` ideally we'd want
# to use a T token related pool, which if deployed for given environment,
# should be present in the latest `goerli`/`sepolia` package. If the
# T-related pool is not yet deployed for given environment, KEEP-related
# cov-pool contracts will be used in all TVL computations (which differs
# from the mainnet behavior, but is acceptable on the test env).

- name: Resolve contracts
shell: bash
run: |
Expand All @@ -141,8 +155,10 @@ jobs:
@keep-network/[email protected] \
@keep-network/keep-ecdsa@${{ inputs.environment }} \
@keep-network/tbtc@${{ inputs.environment }} \
@keep-network/coverage-pools@${{ inputs.environment }} \
@keep-network/random-beacon@${{ steps.set-packages-versions.outputs.random-beacon-contracts-version }} \
@keep-network/[email protected] \
@threshold-network/coverage-pools@npm:@keep-network/coverage-pools@${{ inputs.environment }} \
@keep-network/random-beacon@${{ steps.set-packages-versions.outputs.random-beacon-contracts-version }}

- name: Run postinstall script
shell: bash
# `yarn upgrade` doesn't trigger the `postinstall` script.
Expand Down
Loading