Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): supplement team email remind #9483

Open
wants to merge 7 commits into
base: canary
Choose a base branch
from

Conversation

darkskygit
Copy link
Member

@darkskygit darkskygit commented Jan 2, 2025

Copy link
Member Author

darkskygit commented Jan 2, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 32.67327% with 204 lines in your changes missing coverage. Please review.

Project coverage is 52.28%. Comparing base (a0cba55) to head (7c4e5ec).

Files with missing lines Patch % Lines
...ges/backend/server/src/base/mailer/mail.service.ts 15.04% 96 Missing ⚠️
...ckages/backend/server/src/plugins/payment/quota.ts 13.75% 69 Missing ⚠️
...nd/server/src/core/workspaces/resolvers/service.ts 48.43% 33 Missing ⚠️
...ckend/server/src/core/workspaces/resolvers/team.ts 0.00% 3 Missing ⚠️
packages/backend/server/tests/utils/workspace.ts 87.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9483      +/-   ##
==========================================
- Coverage   52.67%   52.28%   -0.40%     
==========================================
  Files        2174     2174              
  Lines       97577    97865     +288     
  Branches    16620    16576      -44     
==========================================
- Hits        51402    51169     -233     
- Misses      44730    45254     +524     
+ Partials     1445     1442       -3     
Flag Coverage Δ
server-test 76.56% <32.67%> (-1.42%) ⬇️
unittest 32.28% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@darkskygit darkskygit force-pushed the darksky/add-more-email-notification branch 2 times, most recently from 5bb9a0f to 97eb5ce Compare January 6, 2025 02:21
@github-actions github-actions bot added the test Related to test cases label Jan 6, 2025
@darkskygit darkskygit marked this pull request as ready for review January 6, 2025 03:40
@darkskygit darkskygit force-pushed the darksky/add-more-email-notification branch 5 times, most recently from 4c113aa to c015731 Compare January 8, 2025 03:45
@darkskygit darkskygit force-pushed the darksky/add-more-email-notification branch from c015731 to 9658d8c Compare January 8, 2025 09:10
return { start, end };
}

@Cron(CronExpression.EVERY_DAY_AT_MIDNIGHT /* everyday at 12am */)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move it into a separate file like packages/backend/server/src/core/doc/job.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:server test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants