feat(server): new email template #9528
Open
+2,430
−650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
darkskygit
force-pushed
the
darksky/react-based-email-template
branch
from
8f1f2de to
24c5637
Compare
forehalo
reviewed
Jan 6, 2025
| import SignUp, { type SignUpProps } from './sign-up'; | ||
|
|
||
| export const renderInviteEmail = (props: InviteProps): Promise<string> => { | ||
| return render(<Invite {...props} />); |
forehalo
reviewed
Jan 6, 2025
forehalo
reviewed
Jan 6, 2025
darkskygit
force-pushed
the
darksky/add-more-email-notification
branch
from
c6db235 to
d653599
Compare
darkskygit
force-pushed
the
darksky/react-based-email-template
branch
from
f704d82 to
a6acfba
Compare
darkskygit
force-pushed
the
darksky/add-more-email-notification
branch
from
d653599 to
cf394b2
Compare
darkskygit
force-pushed
the
darksky/react-based-email-template
branch
from
a6acfba to
cb96048
Compare
darkskygit
force-pushed
the
darksky/add-more-email-notification
branch
from
cf394b2 to
babe511
Compare
darkskygit
force-pushed
the
darksky/react-based-email-template
branch
from
cb96048 to
cb293da
Compare
forehalo
reviewed
Jan 7, 2025
forehalo
reviewed
Jan 7, 2025
| buttonContent: 'Accept & Join', | ||
| buttonUrl, | ||
| }); | ||
| async sendSignUpMail(to: string, url: string) { |
There was a problem hiding this comment.
we can integrate mailer with event system, so we can decouple it from business services
There was a problem hiding this comment.
the sending results of some mails need to be returne to the frontend for success/failure notifications
so not all mailer dep in bussiness modules can be remove until the notification system is completed
darkskygit
force-pushed
the
darksky/add-more-email-notification
branch
from
babe511 to
4c113aa
Compare
darkskygit
force-pushed
the
darksky/react-based-email-template
branch
from
cb293da to
22e3138
Compare
Brooooooklyn
reviewed
Jan 7, 2025
darkskygit
force-pushed
the
darksky/add-more-email-notification
branch
from
4c113aa to
c015731
Compare
darkskygit
force-pushed
the
darksky/react-based-email-template
branch
from
0d19b34 to
f8929e5
Compare
darkskygit
force-pushed
the
darksky/add-more-email-notification
branch
from
c015731 to
9658d8c
Compare
darkskygit
force-pushed
the
darksky/react-based-email-template
branch
2 times, most recently
from
1fbb7cb to
ea4facb
Compare
darkskygit
force-pushed
the
darksky/react-based-email-template
branch
from
ea4facb to
8fc6b93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use
yarn af server dev:mailto preview all mail templatefix CLOUD-93