Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix long lines #13

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Fix long lines #13

merged 4 commits into from
Nov 21, 2024

Conversation

mcocdawc
Copy link
Contributor

@mcocdawc mcocdawc commented Nov 21, 2024 •
edited
Loading

review after #11 is merged

  • fixes overly long lines
  • added a few missing imports

@mcocdawc
added pre-commit hook
635803b 
requires the developer to once execute

    git config --local core.hooksPath .githooks/
@mcocdawc
fixed overlong lines
601d49d
@mcocdawc mcocdawc mentioned this pull request Nov 21, 2024
Merged
mscho527
mscho527 requested changes Nov 21, 2024
View reviewed changes
Copy link
Member

@mscho527 mscho527 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super super minor thing, but cool cool nice cool otherwise

src/kbe/helper.py Outdated Show resolved Hide resolved
@mcocdawc mcocdawc merged commit 75bea64 into main Nov 21, 2024
3 checks passed
@mscho527 mscho527 deleted the fix_long_lines branch December 3, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mscho527 mscho527 mscho527 approved these changes

@lweisburn lweisburn Awaiting requested review from lweisburn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcocdawc @mscho527