Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize PSO and NM optimizers #115

Merged
merged 15 commits into from
Dec 19, 2024
Merged

Harmonize PSO and NM optimizers #115

merged 15 commits into from
Dec 19, 2024

Conversation

twallema
Copy link
Owner

Pull request checklist

  • I have checked to ensure there aren't other open Pull Requests for the same update/change
  • I have verified all tests work / have added new tests.
  • I have verified all tutorials work.
  • I have updated the documentation accordingly.

Describe your pull request

  • Removed particle_output option from pso.
  • Both PSO and NM now output "theta" (list; optimized parameter values) and "score" (float; corresponding objective function score).
  • Avoids having to call pso/nm.optimize() awkwardly like:
theta = pso.optimize(...)[0]
  • Replace by:
theta, _ = pso.optimize(...)
  • I have considered only outputting theta to make this even "cleaner" but idk, sometimes having the score might be important.

@twallema twallema changed the base branch from master to version_0.2.6 December 19, 2024 13:53
@twallema twallema merged commit 13415c2 into version_0.2.6 Dec 19, 2024
1 check passed
@twallema twallema deleted the harmonize-pso-nm branch December 22, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant