Add e2e tests for the Use as Draft feature #9845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesBochet
approved these changes
Jan 24, 2025
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds end-to-end tests for the workflow draft functionality, focusing on version management and state transitions.
- Added new test file
workflow-use-as-draft.spec.tswith comprehensive tests for using old workflow versions as drafts - Added draft-related button locators (
useAsDraftButton,overrideDraftButton,discardDraftButton) inblank-workflow.tsfixture - Tests cover key scenarios: converting old versions to drafts, handling pending drafts, and proper state transitions between Active/Draft/Archived
- Tests verify proper UI element visibility and workflow content preservation during version changes
2 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+76
to
+82
| this.useAsDraftButton = page.getByRole('button', { name: 'Use as draft' }); | ||
| this.overrideDraftButton = page.getByRole('button', { | ||
| name: 'Override Draft', | ||
| }); | ||
| this.discardDraftButton = page.getByRole('button', { | ||
| name: 'Discard Draft', | ||
| }); |
There was a problem hiding this comment.
style: consider using a common prefix for these related button names to make maintenance easier and prevent typos
Comment on lines
+72
to
+76
| await Promise.all([ | ||
| page.waitForURL(`/object/workflow/${workflowVisualizer.workflowId}`), | ||
|
|
||
| workflowVisualizer.useAsDraftButton.click(), | ||
| ]); |
There was a problem hiding this comment.
logic: The URL wait and button click should be sequential - waiting for URL after clicking the button. Current implementation may lead to flaky tests.
Comment on lines
+158
to
+162
| await Promise.all([ | ||
| page.waitForURL(`/object/workflow/${workflowVisualizer.workflowId}`), | ||
|
|
||
| workflowVisualizer.overrideDraftButton.click(), | ||
| ]); |
There was a problem hiding this comment.
logic: Same issue with URL wait and button click ordering as above. The URL wait should come after the button click.
Log |
DeepaPrasanna
pushed a commit
to DeepaPrasanna/twenty
that referenced
this pull request
Jan 27, 2025
Test with and without a draft version as the last version of the workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test with and without a draft version as the last version of the workflow