Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e tests for the Use as Draft feature #9845

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Add e2e tests for the Use as Draft feature #9845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eda1d5a
test: test we can use as draft when last version was published
Devessier Jan 24, 2025
d9b15db
test: test that we can use a version as draft while a draft is pending
Devessier Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/twenty-e2e-testing/lib/fixtures/blank-workflow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ export class WorkflowVisualizerPage {
readonly workflowNameButton: Locator;
readonly triggerNode: Locator;
readonly background: Locator;
readonly useAsDraftButton: Locator;
readonly overrideDraftButton: Locator;
readonly discardDraftButton: Locator;

#actionNames: Record<WorkflowActionType, string> = {
'create-record': 'Create Record',
Expand Down Expand Up @@ -70,6 +73,13 @@ export class WorkflowVisualizerPage {
});
this.triggerNode = this.#page.getByTestId('rf__node-trigger');
this.background = page.locator('.react-flow__pane');
this.useAsDraftButton = page.getByRole('button', { name: 'Use as draft' });
this.overrideDraftButton = page.getByRole('button', {
name: 'Override Draft',
});
this.discardDraftButton = page.getByRole('button', {
name: 'Discard Draft',
});
Comment on lines +76 to +82
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: consider using a common prefix for these related button names to make maintenance easier and prevent typos

}

async createOneWorkflow() {
Expand Down
175 changes: 175 additions & 0 deletions packages/twenty-e2e-testing/tests/workflow-use-as-draft.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,175 @@
import { expect } from '@playwright/test';
import { test } from '../lib/fixtures/blank-workflow';

test('Use an old version as draft', async ({ workflowVisualizer, page }) => {
await workflowVisualizer.createInitialTrigger('record-created');

await workflowVisualizer.createStep('create-record');

await workflowVisualizer.background.click();

await Promise.all([
expect(workflowVisualizer.workflowStatus).toHaveText('Active'),

workflowVisualizer.activateWorkflowButton.click(),
]);

await Promise.all([
expect(workflowVisualizer.workflowStatus).toHaveText('Draft'),

workflowVisualizer.createStep('delete-record'),
]);

await workflowVisualizer.background.click();

await Promise.all([
expect(workflowVisualizer.workflowStatus).toHaveText('Active'),

workflowVisualizer.activateWorkflowButton.click(),
]);

await expect(workflowVisualizer.triggerNode).toContainText(
'Record is Created',
);
await expect(workflowVisualizer.getAllStepNodes()).toContainText([
'Create Record',
'Delete Record',
]);
await expect(workflowVisualizer.getAllStepNodes()).toHaveCount(2);
await expect(workflowVisualizer.useAsDraftButton).not.toBeVisible();

const workflowsLink = page.getByRole('link', { name: 'Workflows' });
await workflowsLink.click();

const recordTableRowForWorkflow = page.getByRole('row', {
name: workflowVisualizer.workflowName,
});

const linkToWorkflow = recordTableRowForWorkflow.getByRole('link', {
name: workflowVisualizer.workflowName,
});
expect(linkToWorkflow).toBeVisible();

const linkToFirstWorkflowVersion = recordTableRowForWorkflow.getByRole(
'link',
{
name: 'v1',
},
);

await linkToFirstWorkflowVersion.click();

await expect(workflowVisualizer.workflowStatus).toHaveText('Archived');
await expect(workflowVisualizer.useAsDraftButton).toBeVisible();
await expect(workflowVisualizer.triggerNode).toContainText(
'Record is Created',
);
await expect(workflowVisualizer.getAllStepNodes()).toContainText([
'Create Record',
]);
await expect(workflowVisualizer.getAllStepNodes()).toHaveCount(1);

await Promise.all([
page.waitForURL(`/object/workflow/${workflowVisualizer.workflowId}`),

workflowVisualizer.useAsDraftButton.click(),
]);
Comment on lines +72 to +76
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: The URL wait and button click should be sequential - waiting for URL after clicking the button. Current implementation may lead to flaky tests.


await expect(workflowVisualizer.workflowStatus).toHaveText('Draft');
await expect(workflowVisualizer.useAsDraftButton).not.toBeVisible();
await expect(workflowVisualizer.triggerNode).toContainText(
'Record is Created',
);
await expect(workflowVisualizer.getAllStepNodes()).toContainText([
'Create Record',
]);
await expect(workflowVisualizer.getAllStepNodes()).toHaveCount(1);
});

test('Use an old version as draft while having a pending draft version', async ({
workflowVisualizer,
page,
}) => {
await workflowVisualizer.createInitialTrigger('record-created');

await workflowVisualizer.createStep('create-record');

await workflowVisualizer.background.click();

await Promise.all([
expect(workflowVisualizer.workflowStatus).toHaveText('Active'),

workflowVisualizer.activateWorkflowButton.click(),
]);

await Promise.all([
expect(workflowVisualizer.workflowStatus).toHaveText('Draft'),

workflowVisualizer.createStep('delete-record'),
]);

await expect(workflowVisualizer.triggerNode).toContainText(
'Record is Created',
);
await expect(workflowVisualizer.getAllStepNodes()).toContainText([
'Create Record',
'Delete Record',
]);
await expect(workflowVisualizer.getAllStepNodes()).toHaveCount(2);
await expect(workflowVisualizer.useAsDraftButton).not.toBeVisible();

const workflowsLink = page.getByRole('link', { name: 'Workflows' });
await workflowsLink.click();

const recordTableRowForWorkflow = page.getByRole('row', {
name: workflowVisualizer.workflowName,
});

const linkToWorkflow = recordTableRowForWorkflow.getByRole('link', {
name: workflowVisualizer.workflowName,
});
expect(linkToWorkflow).toBeVisible();

const linkToFirstWorkflowVersion = recordTableRowForWorkflow.getByRole(
'link',
{
name: 'v1',
},
);

await linkToFirstWorkflowVersion.click();

await expect(workflowVisualizer.workflowStatus).toHaveText('Active');
await expect(workflowVisualizer.useAsDraftButton).toBeVisible();
await expect(workflowVisualizer.triggerNode).toContainText(
'Record is Created',
);
await expect(workflowVisualizer.getAllStepNodes()).toContainText([
'Create Record',
]);
await expect(workflowVisualizer.getAllStepNodes()).toHaveCount(1);

await Promise.all([
expect(workflowVisualizer.overrideDraftButton).toBeVisible(),

workflowVisualizer.useAsDraftButton.click(),
]);

await Promise.all([
page.waitForURL(`/object/workflow/${workflowVisualizer.workflowId}`),

workflowVisualizer.overrideDraftButton.click(),
]);
Comment on lines +158 to +162
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Same issue with URL wait and button click ordering as above. The URL wait should come after the button click.


await expect(workflowVisualizer.workflowStatus).toHaveText('Draft');
await expect(workflowVisualizer.useAsDraftButton).not.toBeVisible();
await expect(workflowVisualizer.triggerNode).toContainText(
'Record is Created',
);
await expect(workflowVisualizer.getAllStepNodes()).toContainText([
'Create Record',
]);
await expect(workflowVisualizer.getAllStepNodes()).toHaveCount(1);
await expect(workflowVisualizer.activateWorkflowButton).toBeVisible();
await expect(workflowVisualizer.discardDraftButton).toBeVisible();
});
Loading