Miscellaneous fix grab bag #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZoopOTheGoop
force-pushed
the
misc-fixes
branch
3 times, most recently
from
4a766d7 to
1216039
Compare
ZoopOTheGoop
force-pushed
the
misc-fixes
branch
6 times, most recently
from
bceb730 to
05317a7
Compare
|
Hooray, finally got actions passing again. This should make future work this pulse go much faster. Everything else I'm going to do is going to be based on this branch so feel free to suggest commits to drop, but ultimately most of them are pretty important but not worth their own PR. |
ZoopOTheGoop
force-pushed
the
misc-fixes
branch
from
5e5caa8 to
dbe09f8
Compare
This was referenced Feb 27, 2024
Closed
Merged
ZoopOTheGoop
force-pushed
the
misc-fixes
branch
from
326c39b to
a08ca67
Compare
ZoopOTheGoop
force-pushed
the
misc-fixes
branch
from
a08ca67 to
4e846aa
Compare
tim-hm
approved these changes
Feb 27, 2024
added 6 commits
February 27, 2024 09:25
Turns out `ubuntu-latest` is also Jammy, whose `protobuf-compiler` version is too low to use the features that are no longer experimental on later releases. So we need the experimental flag.
It's redundant, it's a required dependency of `protobuf-compiler`.
ZoopOTheGoop
force-pushed
the
misc-fixes
branch
from
4e846aa to
9f3cebc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were originally all separate PRs, but I ultimately ended up combining them into one because a lot of them require the others (in particular the
dotenvyone is load bearing).This should fix the CI/CD issue as well.