clm lake fix: pressure is not density + #142 and #148 #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuelTrahanNOAA
requested review from
tanyasmirnova,
grantfirl,
Qingfu-Liu and
dustinswales
as code owners
|
@SamuelTrahanNOAA This PR also fixes the crash with the use of the CLM lake model caused by a lake point with the lake depth < 10 cm. |
tanyasmirnova
approved these changes
Dec 15, 2023
dustinswales
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
@SamuelTrahanNOAA Looks good. Just a small request to comment on a new parameter
grantfirl
approved these changes
Dec 18, 2023
|
This PR fixes another bug I forgot to mention. I've added an issue for it: |
35 tasks
Qingfu-Liu
approved these changes
Dec 19, 2023
tanyasmirnova
approved these changes
Dec 19, 2023
|
@JiliDong-NOAA - Please confirm that I merged your changes into this branch correctly. |
SamuelTrahanNOAA
changed the title
merge looks correct. |
|
All tests were finished at ufs-community/ufs-weather-model#2044. @grantfirl @dustinswales @tanyasmirnova @Qingfu-Liu Can you merge this pr? |
|
Done. Note that the CI tests will fail until fv3atm #736 is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs #142 and #148 are combined into this one
The CLM Lake Model was using near-surface pressure in place of near-surface density. This corrects the code to user near-surface density instead.
These two pull requests are included in this one. They can be closed once this one is merged.
Due to including #148:
And from #142: