-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLM Lake pressure is not density and GFS Diagnostics: weasdi is not snodi + #2047, #2053, and #2056 #2044
CLM Lake pressure is not density and GFS Diagnostics: weasdi is not snodi + #2047, #2053, and #2056 #2044
Conversation
@jkbk2004 @FernandoAndrade-NOAA - I'd like to combine PR #2047 into this one. The RRFS model needs them urgently. They're both small tweaks to RRFS physics code, which change answers for (mostly) RRFS physics variants. |
Sure! I updated the queue table to work on this pr after #2041. |
I'll wait until tomorrow to merge #2047 into this PR. That'll give more time for people to look at the PRs independently. |
I am waiting to hear back from @JiliDong-NOAA about the status of #2056 On a local working copy, I've merged #2047 and #2056 into this PR. Conflicts were easy to resolve. I'd rather not test twice. I'm waiting to hear back from @JiliDong-NOAA that #2056 is ready for final testing. |
Jili says the PR #2056 is ready for testing. I'll begin momentarily. |
Dusan's recommended fix from 2015 added to hercules fv3_slurm file. Tests passed for regional_netcdf_parallel and the two wrtGauss cases, so were re-enabled for hercules. |
We can start merging process. |
@jkbk2004 Are we adding the template? @SamuelTrahanNOAA any changes you'd prefer to make to the commit message? |
@BrianCurtis-NOAA - How is this? There are so many PRs and issues involved, I had to trim the list down a bit.
|
@BrianCurtis-NOAA - Sorry, I missed a bit
|
Yeah I too was trying to piece together all the changes. This look good. Thanks. |
Is there an issue I should cite for #2053? Or is it solely a PR? |
Just the PR. |
This PR should also close Issue #2015 |
@BrianCurtis-NOAA @jkbk2004 - I have updated the commit message to reflect this:
|
@SamuelTrahanNOAA all sub component PRs were merged. |
This PR is ready for final review and merge. I've reverted .gitmodules. The FV3 and CMEPS point to their authoritative branches and URLs. |
PR Author Checklist:
Description
PRs #2047, #2053, and #2056 are combined into this one.
Fixes two bugs:
Fixes are from @tanyasmirnova
Commit Message
Linked Issues and Pull Requests
Associated UFSWM Issue to close
closes revisions to snowfall melting and accumulation from @tanyasmirnova #2047
closes fix crash when using clm lake and GFS PBL/sfclay #2056
fixes multiple netcdf_parallel tests fail on hercules #2015
Due to combining #2056:
Subcomponent Pull Requests
Blocking Dependencies
None
Subcomponents involved:
Anticipated Changes
Input data
Regression Tests:
All tests with "hrrr" or "clm_lake" in their name.
List of tests in rt.conf format
Libraries
Code Managers Log
Testing Log: