-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split force for publish descendants into separate options for publish unpublish and re-publish unedited (13) #18249
Merged
AndyButland
merged 14 commits into
v13/dev
from
v13/feature/force-republish-descendents
Feb 12, 2025
Merged
Split force for publish descendants into separate options for publish unpublish and re-publish unedited (13) #18249
AndyButland
merged 14 commits into
v13/dev
from
v13/feature/force-republish-descendents
Feb 12, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unpublish and re-publish unedited.
…hub.com/umbraco/Umbraco-CMS into v13/feature/force-republish-descendents
1 task
Migaroez
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested out ok, UI explains the concepts well in my opinion.
Great work 🚀
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Resolves: #13739
Description
We currently have a single option on the "Publish descendants" dialog, where an editor can "Include unpublished content items". There are cases though we we also want to force a publish even if there are no changes to publish (so notification handlers can fire, indexes can get rebuilt etc.).
So this PR introduces a second option.
In code we have a
force
parameter that gets passed up to the content service. I've split that into two so we can be be more explicit about what exactly we are forcing (publish of unpublished or publish of unchanged).To Test: