Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal TF: Deprecated data domain and related SSL SSM parameters #416

Merged
merged 2 commits into from
May 20, 2024

Conversation

victorskl
Copy link
Member

  • This removes the following exported system parameters:
    /data_portal/backend/api_domain_name
    /data_portal/backend/certificate_arn
    
  • At consumer side, these should be replaced new system parameter coordinate at:
    /data_portal/backend/api_domain_name2
    /data_portal/backend/certificate_arn2
    
  • This will go multiple stages and this is the Phase 1 of
    Migrate to new Portal domain name #272

* This removes the following exported system parameters:
  ```
  /data_portal/backend/api_domain_name
  /data_portal/backend/certificate_arn
  ```
* At consumer side, these should be replaced new system parameter coordinate at:
  ```
  /data_portal/backend/api_domain_name2
  /data_portal/backend/certificate_arn2
  ```
* This will go multiple stages and this is the Phase 1 of
  #272
@victorskl
Copy link
Member Author

Related umccr/data-portal-apis#666

@victorskl
Copy link
Member Author

Wait for ^^ Status Page & sscheck, at least.

@victorskl
Copy link
Member Author

victorskl commented Apr 12, 2024

Perhaps we can retain these SSM param and, update to new domain url values. So that downstream stacks doesn't need to do anything. It will feel like redirect. One to discuss.

@victorskl
Copy link
Member Author

Going to do redirect approach and retain the ssm param for backward compatibility.

* Just point them to newer Portal domain and SSL cert ARN instead
@victorskl
Copy link
Member Author

Found out that Pierian accession pipeline also leverage this Portal domain name param.

https://github.com/umccr/cttso-ica-to-pieriandx/blob/main/deploy/cttso-ica-to-pieriandx-cdk/constants.ts#L22-L23

@victorskl victorskl added this to the 202N.0N milestone May 17, 2024
@victorskl victorskl merged commit 4db8ab4 into master May 20, 2024
1 check passed
@victorskl victorskl deleted the deprecate-data-domain-ssm-param branch May 20, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants