refactor: omit HTMLAttributes from grid column types #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
reviewed
Dec 19, 2023
src/GridTreeColumn.ts
Outdated
| export * from './generated/GridTreeColumn.js'; | ||
|
|
||
| export type GridTreeColumnProps<TItem> = Partial< | ||
| Omit<_GridTreeColumnProps<TItem>, 'footerRenderer' | 'headerRenderer' | keyof OmittedGridColumnHTMLAttributes<TItem>> |
There was a problem hiding this comment.
Should we omit children and renderer here to align with other columns e.g. GridSortColumn?
There was a problem hiding this comment.
Good catch. Omitted them from the tree column also.
web-padawan
previously approved these changes
Dec 19, 2023
web-padawan
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Grid column types don't need to expose properties such as
style,draggableoronClickfromHTMLAttributes. This PR omits mostHTMLAttributesprops from each Grid column type.Before:
After:
Type of change
Refactor