Java: Fix CI. #1790
Merged
Java: Fix CI. #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
added
java
Signed-off-by: Yury-Fridlyand <[email protected]>
acarbonetto
approved these changes
Jul 3, 2024
| @@ -126,7 +126,7 @@ jobs: | |||
| - 17 | |||
| runs-on: ubuntu-latest | |||
| container: amazonlinux:latest | |||
| timeout-minutes: 15 | |||
| timeout-minutes: 35 | |||
There was a problem hiding this comment.
Our main CI is limited by 35, this one takes more time, due to VM/container deploy.
Should I update both? Actual run times are GH linux <10 min, GH mac <12, AWS VM <17
| @@ -108,7 +108,7 @@ jobs: | |||
| continue-on-error: true | |||
| uses: actions/upload-artifact@v4 | |||
| with: | |||
| name: test-reports-java-${{ matrix.java }}-redis-${{ matrix.redis }}-${{ matrix.host.RUNNER }} | |||
| name: test-reports-java-${{ matrix.java }}-${{ matrix.engine.type }}-${{ matrix.engine.version }}-${{ matrix.host.RUNNER }} | |||
There was a problem hiding this comment.
strangely, engine.type is always valkey
There was a problem hiding this comment.
Yeah and redis never installed. @barshaul ?
aaron-congo
approved these changes
Jul 5, 2024
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jul 16, 2024
* Fix CI. Signed-off-by: Yury-Fridlyand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Fixes
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.