Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: Fix CI. #1790

Merged
merged 3 commits into from
Jul 5, 2024
Merged

Java: Fix CI. #1790

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
954bb86
Fix CI.
Yury-Fridlyand Jul 3, 2024
297d8fb
Typo fix + timeout.
Yury-Fridlyand Jul 3, 2024
ac9dac1
Merge branch 'main' into java/integ_yuryf_fix_ci_artifact_names
Yury-Fridlyand Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/java.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ jobs:
continue-on-error: true
uses: actions/upload-artifact@v4
with:
name: test-reports-java-${{ matrix.java }}-redis-${{ matrix.redis }}-${{ matrix.host.RUNNER }}
name: test-reports-java-${{ matrix.java }}-${{ matrix.engine.type }}-${{ matrix.engine.version }}-${{ matrix.host.RUNNER }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strangely, engine.type is always valkey

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah and redis never installed. @barshaul ?

path: |
java/client/build/reports/**
java/integTest/build/reports/**
Expand All @@ -126,7 +126,7 @@ jobs:
- 17
runs-on: ubuntu-latest
container: amazonlinux:latest
timeout-minutes: 15
timeout-minutes: 35
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make this 25?

Copy link
Collaborator Author

@Yury-Fridlyand Yury-Fridlyand Jul 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our main CI is limited by 35, this one takes more time, due to VM/container deploy.
Should I update both? Actual run times are GH linux <10 min, GH mac <12, AWS VM <17

steps:
- name: Install git
run: |
Expand Down
Loading