Link release notes in the Documention menu #140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Santo Leto <[email protected]>
stockholmux
requested changes
Sep 24, 2024
| @@ -12,3 +12,4 @@ page_template = "docs-page.html" | |||
| * [ACL](/topics/acl/) | |||
| * Valkey Manual | |||
| * [Keyspace Notifications](/topics/keyspace/) | |||
| * [Release Notes](topics/release-notes/) | |||
There was a problem hiding this comment.
humm. I don't mind the idea of linking the release notes but /topics/release-notes/ isn't a documentation topic in valkey-doc
There was a problem hiding this comment.
Hi @stockholmux ! Thanks for reviewing this! When I created this PR it was in combination with valkey-io/valkey-doc#171 . If valkey-io/valkey-doc#171 is not going to be included, then we can close this one. Hope this helps
|
I'm going to close this one in lieu of work on #145 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the recently created release notes page in the
Documentationmenu. Reference: valkey-io/valkey-doc#171Issues Resolved
No GH issue open.
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.