Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link release notes in the Documention menu #140

Closed
wants to merge 1 commit into from
Closed

Link release notes in the Documention menu #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions content/docs/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,4 @@ page_template = "docs-page.html"
* [ACL](/topics/acl/)
* Valkey Manual
* [Keyspace Notifications](/topics/keyspace/)
* [Release Notes](topics/release-notes/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

humm. I don't mind the idea of linking the release notes but /topics/release-notes/ isn't a documentation topic in valkey-doc

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @stockholmux ! Thanks for reviewing this! When I created this PR it was in combination with valkey-io/valkey-doc#171 . If valkey-io/valkey-doc#171 is not going to be included, then we can close this one. Hope this helps