Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSDK-9305 Add CI #10

Merged
merged 13 commits into from
Nov 26, 2024
Merged

RSDK-9305 Add CI #10

merged 13 commits into from
Nov 26, 2024

Conversation

oliviamiller
Copy link
Collaborator

Adding ci workflows for test, linting and deploying. Will make a separate PR for implementing the lint code changes to avoid making this pr super large.

Copy link
Collaborator

@randhid randhid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to go 1.23 in your linter to match your go mod file.

- name: Set up Go
uses: actions/setup-go@v3
with:
go-version: 1.21
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be go 1.23.

tools.go Outdated
Comment on lines 4 to 8
package tools

import (
_ "github.com/golangci/golangci-lint/cmd/golangci-lint"
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might want this in a separate folder etc/tools.go

@oliviamiller oliviamiller merged commit ce388af into main Nov 26, 2024
1 check failed
@oliviamiller oliviamiller deleted the cibuilding branch November 27, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants