Bug fix and better logging #26
Merged
+38
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
oliviamiller
commented
Feb 14, 2025
oliviamiller
commented
- Added mutex around data file, John hit an issue where two entries for the same Dev EUI were written to the file.
- Parsing confirmed data up messages instead of erroring, will add implementation for sending the confirmation downlink in a new PR
- Adding more info to a few of the logs for easier debugging
JohnN193
approved these changes
Feb 14, 2025
gateway/gateway.go
Outdated
| @@ -371,8 +372,21 @@ func (g *gateway) handlePacket(ctx context.Context, payload []byte) { | |||
| return | |||
| } | |||
| g.updateReadings(name, readings) | |||
| case 0x80: | |||
| g.logger.Infof("received confirmed data uplink") | |||
There was a problem hiding this comment.
thanks for adding these! In a future pr we should move the "received" logs down to debug I think
There was a problem hiding this comment.
on a similar note, might be worth adding a "join accepted" log as well
randhid
reviewed
Feb 14, 2025
| @@ -458,10 +473,12 @@ func (g *gateway) DoCommand(ctx context.Context, cmd map[string]interface{}) (ma | |||
| // searchForDeviceInfoInFile searhces for device address match in the module's data file and returns the device info. | |||
| func (g *gateway) searchForDeviceInFile(devEUI []byte) (*deviceInfo, error) { | |||
| // read all the saved devices from the file | |||
| g.dataMu.Lock() | |||
There was a problem hiding this comment.
Why not defer the unlock right after?
There was a problem hiding this comment.
You've got a case where you return and don't unlock in the error.
There was a problem hiding this comment.
thanks for catching, switching to defer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.