[RSDK-7953] Consolidate build workflow for all archs part 2 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexbabe
force-pushed
the
hexbabe-patch-1
branch
3 times, most recently
from
4392786 to
2e6321a
Compare
hexbabe
force-pushed
the
hexbabe-patch-1
branch
from
2e6321a to
b9a89bb
Compare
hexbabe
force-pushed
the
hexbabe-patch-1
branch
from
10bc437 to
5446ba3
Compare
hexbabe
changed the title
hexbabe
force-pushed
the
hexbabe-patch-1
branch
7 times, most recently
from
45a0b16 to
3dcf53a
Compare
hexbabe
force-pushed
the
hexbabe-patch-1
branch
from
3dcf53a to
7123c91
Compare
hexbabe
force-pushed
the
hexbabe-patch-1
branch
from
1bcf700 to
1150314
Compare
hexbabe
force-pushed
the
hexbabe-patch-1
branch
from
1150314 to
eed795d
Compare
hexbabe
commented
Sep 13, 2024
| @@ -1,6 +1,6 @@ | |||
| name: Integration test using mediamtx | |||
|
|
|||
| on: [push, pull_request] | |||
| on: push | |||
There was a problem hiding this comment.
This causes the workflow to run twice. Just need push here
randhid
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we were to continue using #44 only, we would lose support for Bullseye. Buildjet arm runners use a newer version of glibc. We should use canon's antique profile. This will also better align our manual test builds with deployed builds.
Update: I added a condition that doesn't use canon for Android. For some reason android builds don't work in the canon docker antique environment. The current android build flow does not use Docker or canon
Tests:
"Successful" linux/arm64 CI run
"Successful" android/arm64 CI run
"Successful" linux/amd64 CI run
"successful" in quotes meaning that even though the CI technically failed, it failed on the upload step with a semver error, which is expected since we don't want them to actually upload yet.