[RSDK-9843] Support mpeg4 to address codecInfo error on some RTSP streams #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanavery
approved these changes
Jan 27, 2025
rtsp.go
Outdated
|
|
||
| // Initialize the rawDecoder with MPEG4 config data | ||
| if f.Config != nil { | ||
| // Prepend MPEG4 Visual Object Sequence (VOS) and Video Object (VO) start codes if not present |
There was a problem hiding this comment.
What do we mean by "if not present" here?
There was a problem hiding this comment.
lol there's no conditional in the code to justify using "if" here (anymore). I'll delete that
| C.avcodec_close(codecCtx) | ||
| return nil, errors.New("av_malloc() failed for extradata") | ||
| } | ||
| C.memcpy(unsafe.Pointer(codecCtx.extradata), unsafe.Pointer(&extraData[0]), C.size_t(codecCtx.extradata_size)) |
There was a problem hiding this comment.
Nicely done -- did not realize this how you set the global headers for MPEG4 decoder.
There was a problem hiding this comment.
I didn't either! I tried to make h264/5 also use this global headers flow, but I think NAL units work differently i.e. every frame
We do not :,) Waiting on some people to tell us what camera we should buy if that's an option for actually testing this feature |
hexbabe
changed the title
randhid
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RSDK-9843
Adds new model
viam:viamrtsp:rtsp-mpeg4. Adds support for mpeg4 including codec detection with agnostic model. Adds integration test.Manual Testing