add empty cred #77
Merged
add empty cred #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randhid
approved these changes
Jan 28, 2025
randhid
reviewed
Jan 28, 2025
| @@ -20,6 +20,7 @@ import ( | |||
| var ( | |||
| Model = viamrtsp.Family.WithModel("onvif") | |||
| errNoCamerasFound = errors.New("no cameras found, ensure cameras are working or check credentials") | |||
| emptyCred = device.Credentials{} | |||
There was a problem hiding this comment.
not blocking, but add test?
There was a problem hiding this comment.
I currently cannot test this, since I need to be able to add camera mocks to these tests.
Once the circular dependencies can be removed(after discovercomponents is deleted) we can move the discovery service into the viamonvif folder. then I can use the camera mocks defined in those tests and add a way to use them with onvif discovery
There was a problem hiding this comment.
Right, thanks for bringing that up again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed that the new discovery function still needs a credential to be passed in to run. by adding an empty credential it ensures that insecure cameras on the network are found