-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RSDK-9935] - Iframe only decode #90
Merged
nicksanford
merged 14 commits into
viam-modules:main
from
nicksanford:RSDK-9935-iframe-only-decode
Feb 11, 2025
Merged
[RSDK-9935] - Iframe only decode #90
nicksanford
merged 14 commits into
viam-modules:main
from
nicksanford:RSDK-9935-iframe-only-decode
Feb 11, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicksanford
commented
Feb 7, 2025
nicksanford
commented
Feb 7, 2025
nicksanford
commented
Feb 7, 2025
randhid
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nits
randhid
reviewed
Feb 11, 2025
Co-authored-by: randhid <[email protected]>
Co-authored-by: randhid <[email protected]>
Co-authored-by: randhid <[email protected]>
Co-authored-by: randhid <[email protected]>
hexbabe
pushed a commit
to hexbabe/sean-viamrtsp
that referenced
this pull request
Feb 14, 2025
* wip * wip * wip * wip * add warnings * wip * wip * wip * wip * wip * Update rtsp.go Co-authored-by: randhid <[email protected]> * Update rtsp.go Co-authored-by: randhid <[email protected]> * Update rtsp.go Co-authored-by: randhid <[email protected]> * Update rtsp.go Co-authored-by: randhid <[email protected]> --------- Co-authored-by: randhid <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Changes:
i_frame_only_decode
config option.false
by default. Iftrue
only iframes will be decoded. Works both withlazy_decode: true
andlazy_decode: false
i_frame_only_decode
config option is enabled on any codecs other than h264 and h265Manual Tests: