[RSDK-9629] remove DiscoverComponents #96
+87
−979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexbabe
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
To clarify, this is
- A modification to the example to not use the now-deprecated-on-latest-ver DiscoverComponents.
- Putting the discovery service registration in the same dir as the core logic
We also remove the viamrtsp dep in the example bc we don't need access to models anymore.
hexbabe
reviewed
Feb 13, 2025
Yeah that’s the big thing, and it lets me move the discovery service because we won’t get circular dependencies now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://viam.atlassian.net/browse/RSDK-9629
Removes DiscoverComponents and puts the viamonvif discovery service with the rest of the viamonvif logic.