Move startstop1 uid finding feature into a separate component #1810
Conversation
| "mqtt/generator/1", but that is not guaranteed. | ||
|
|
||
| So, unlike for many other service types, these services these do not refer to different generator | ||
| instances; instead, they are used to distinguish between two different types of generators. |
There was a problem hiding this comment.
@izak could you please check these comments - is this correct or have I misunderstood the startstop0/startstop1 differentiation?
There was a problem hiding this comment.
This is correct. It is not ideal of course: we prefer that the 4th component in the service path not be used for identification, but right now it is what it is.
The only correction I need to make is that startstop1 is for more than just FischerPanda. It will control any genset service with start-stop capability, which also includes ComAp and DSE controllers and maybe more in future. The concept is the same though: Genset services that have their own built-in start/stop functionality that can be remotely commanded.
There was a problem hiding this comment.
Thanks! Updated as suggested.
This is a general cleanup to make it clear how to reuse this functionality from elsewhere if that is needed.
blammit
force-pushed
the
genset-startstop-helper
branch
from
d3c8875 to
6cc20dd
Compare
This is a general cleanup to make it clear how to reuse this functionality from elsewhere if that is needed.