-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miketrahearn/1239 align genset settings and control card #1812
Miketrahearn/1239 align genset settings and control card #1812
Conversation
62ef855
to
3fe657d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a reference to the issue number in each commit?
b62d33d
to
b4d116a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also patch data/mock/GeneratorsImpl.qml to set Enabled=1 for the mock generators? Like this:
diff --git a/data/mock/GeneratorsImpl.qml b/data/mock/GeneratorsImpl.qml
index 642df01d..a5c715bf 100644
--- a/data/mock/GeneratorsImpl.qml
+++ b/data/mock/GeneratorsImpl.qml
@@ -33,6 +33,7 @@ QtObject {
_customName.setValue("Start/Stop generator")
_state.setValue(VenusOS.Generators_State_Running)
_runningBy.setValue(VenusOS.Generators_RunningBy_Soc)
+ Global.mockDataSimulator.setMockValue(generator.serviceUid + "/Enabled", 1)
setAutoStart(true)
}
Otherwise they won't show up in the generator cards.
Aside from that, LGTM. I spotted one other thing - could you add the common dialog component as well? As per comment.
b4d116a
to
b6aa09b
Compare
No description provided.