Rework ListItem layout and add ListLink component #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blammit
requested review from
chriadam,
DanielMcInnes and
MikeTrahearn-Qinetic
|
@mr-manuel can you try this out and see if it is suitable? |
blammit
force-pushed
the
blam/link-component
branch
from
4092b36 to
9c088ce
Compare
The layouts of list items can certainly be improved now that we have ported all of the settings from gui-v1 and have a better idea of the different layouts that are required. Ideally the spacing/margins would be consolidated to have a common set across the board, instead of having highly customized values for different items. |
Allow the bottom content horizontal sizing to be customized: - 'stretch' size mode: bottom content spans the full width of the list item (as per existing behavior). - 'compact' size mode: the bottom content spans from the list item's left side, to the edge of the item's right-hand content. The 'compact' size is useful if the right-hand content is taller than the primaryLabel text; in this case, the caption text should wrap at the edge of the right-hand content, instead of dropping below it. Use a GridLayout with row and column spans to make this layout more easily configurable. Part of #1811
These are no longer needed. The 'spacing' was confusing in any case because there are multiple types of spacing within ListItem.
blammit
force-pushed
the
blam/link-component
branch
from
9c088ce to
8edf37c
Compare
|
@blammit I was now able to test it. Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.