ListItem: rename 'allowed' to 'preferredVisible' and do other clean-up #1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There isn't a good use case for having the defaultAllowed property, and it forces components to refer to an extra property. Remove it and just refer to userHasReadAccess directly in ListItem.
'allowed' implies some access control is involved, which is often not the case, as an item's visibility often depends on whether a backend value is available, or whether another setting is enabled. Rename it to 'preferredVisible' as the property indicates whether an item should be visible, and is used as the input value for 'visible'. Fixes #1843
This is no longer needed as the implicitHeight binding has been greatly simplified.
blammit
requested review from
chriadam,
DanielMcInnes and
MikeTrahearn-Qinetic
MikeTrahearn-Qinetic
approved these changes
Jan 15, 2025
DanielMcInnes
approved these changes
Jan 15, 2025
|
@jhofstee @dirkjanfaber @ReinvdZee @martinbosma @izak please note, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.