Refactor orientation mapping3 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@viljarjf Note that I didn't spend too much time making sure all of the standard are correct. It might be nice to check those another time just to make sure. |
|
@CSSFrancis How do you plan on continuing this? Should we close our two PRs on pyxem in favour of this branch? There are a couple things with the plotting that need fixing still |
CSSFrancis
force-pushed
the
refactor_orientation_mapping3
branch
4 times, most recently
from
f0f0e16 to
c52505f
Compare
Update: Update versions
Fixed indexing error in `get_direct_beam_position`
BugFix: Fix "Broken" link
CSSFrancis
force-pushed
the
refactor_orientation_mapping3
branch
from
9a7ee01 to
3b25305
Compare
CSSFrancis
force-pushed
the
refactor_orientation_mapping3
branch
from
a7c8864 to
2d93837
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@viljarjf I added some examples (which will be good for testing as well) and rebased this branch.
This requires:
We might have to change things if pyxem/orix#499 isn't merged.