-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve rand tests #265
Improve rand tests #265
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #265 +/- ##
======================================
Coverage 98.0% 98.1%
======================================
Files 291 291
Lines 6914 6908 -6
Branches 786 774 -12
======================================
- Hits 6781 6777 -4
Misses 90 90
+ Partials 43 41 -2 ☔ View full report in Codecov by Sentry. |
Sorry for all the noise on this one. I'll be leaving this one alone for now so it stays stable. Should be good to be reviewed, @purva-thakre ! |
Just a ping for this PR and #271 to see if we want to get these in before some of the other PRs coming down the pipe (might make the merging easier if we chuck these in first) fyi @purva-thakre |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for a few minor changes.
I think we do want to use pytest.raises
to test if an error is raised correctly. One thing I noticed after working on some of the issues in #217 is, if numpy is used to check things like this, the covered line might show up as uncovered to pytest.
Co-authored-by: Purva Thakre <[email protected]>
Co-authored-by: Purva Thakre <[email protected]>
Co-authored-by: Purva Thakre <[email protected]>
Co-authored-by: Purva Thakre <[email protected]>
Co-authored-by: Purva Thakre <[email protected]>
Co-authored-by: Purva Thakre <[email protected]>
Co-authored-by: Purva Thakre <[email protected]>
Co-authored-by: Purva Thakre <[email protected]>
Co-authored-by: Purva Thakre <[email protected]>
Co-authored-by: Purva Thakre <[email protected]>
Thanks again for the review, @purva-thakre ! |
Started off doing some improvements for the testing in
rand/
and hit a few additional areas. Namely:inner_product
andouter_product
functions (these most likely can be removed as they are just numpy wrappers)vectors_from_gram_matrix
andgram_matrix_to_vectors
functions.