Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master linting #1397

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Master linting #1397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
45ac98d
creator: Fix pylint error in run_creator
bcl May 30, 2024
3b8d5f8
tests: Fix image_minimizer test dnf usage
bcl Jul 14, 2023
e7fabc3
Makefile: Turn off seccomp for test-in-podman
bcl Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ test-in-podman:
@mkdir -p `pwd`/.test-results
$(DOCKER) run --rm -v `pwd`/.test-results/:/test-results \
-v `pwd`:/lorax-ro:ro --security-opt label=disable \
--security-opt seccomp=unconfined \
--env RUN_TESTS="$(RUN_TESTS)" \
welder/lorax-tests:$(IMAGE_RELEASE) make test-in-copy
# rootless podman leaves them owned by the container UID
Expand Down
1 change: 1 addition & 0 deletions src/pylorax/creator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,6 +651,7 @@ def run_creator(opts, cancel_func=None):
(Yes, this is not ideal, but we can fix that later)
"""
result_dir = None
disk_img = None

# Parse the kickstart
if opts.ks:
Expand Down
2 changes: 1 addition & 1 deletion tests/image-minimizer/test_minimizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
class MinimizerTestCase(unittest.TestCase):
def test_minimizer_ok(self):
with tempfile.TemporaryDirectory(prefix="minimize.test.") as rootdir:
check_call(["dnf", "--releasever=/", "--installroot", rootdir, "install", "-y", \
check_call(["dnf", "--use-host-config", "--installroot", rootdir, "install", "-y", \
"filesystem", "tzdata"])

im = ImageMinimizer("./tests/image-minimizer/im-script.txt", rootdir, False, False)
Expand Down