Editorial: Change exceptions to be more precise #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to include some of the other changes. Should we work on those first and then rebase this? |
|
Whoops, sorry about that. I hadn't meant to include those other changes here. There's some merge conflicts so I'll rebase once the other changes merge |
annevk
approved these changes
Nov 2, 2022
|
It seems this has been impacted by whatwg/whatwg.org#401. Will try to sort that, but not sure about the timeline. |
|
By the way, you want stuff like "Fixes #63" to be in the commit message body so you don't have to visit the PR to find the issue discussion. |
a-sully
added a commit
to WICG/file-system-access
that referenced
this pull request
Jun 20, 2023
Before: `throw a {{SecurityError}}`
After: `[=throw=] a "{{SecurityError}}" {{DOMException}}`
See whatwg/fs#63 and whatwg/fs#89. Fixed in the upstream spec in whatwg/fs#70 and whatwg/fs#91, respectively
github-actions bot
added a commit
to WICG/file-system-access
that referenced
this pull request
Jun 20, 2023
Before: `throw a {{SecurityError}}`
After: `[=throw=] a "{{SecurityError}}" {{DOMException}}`
See whatwg/fs#63 and whatwg/fs#89. Fixed in the upstream spec in whatwg/fs#70 and whatwg/fs#91, respectively
SHA: a350a87
Reason: push, by @a-sully
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63
Before: {{InvalidStateError Error}}
After: "{{InvalidStateError Error}}" {{DOMException}}
Preview | Diff