-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add getSenderNameByMessageId useCase WPB-11723 #3186
feat: Add getSenderNameByMessageId useCase WPB-11723 #3186
Conversation
persistence/src/commonMain/db_user/com/wire/kalium/persistence/Users.sq
Outdated
Show resolved
Hide resolved
persistence/src/commonMain/kotlin/com/wire/kalium/persistence/dao/message/MessageDAOImpl.kt
Show resolved
Hide resolved
Bencher Report
Click to view all benchmark results
|
Datadog ReportBranch report: ✅ 0 Failed, 3259 Passed, 107 Skipped, 1m 1.7s Total Time |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3186 +/- ##
===========================================
+ Coverage 54.11% 54.13% +0.01%
===========================================
Files 1260 1261 +1
Lines 36730 36748 +18
Branches 3733 3734 +1
===========================================
+ Hits 19877 19894 +17
- Misses 15415 15416 +1
Partials 1438 1438
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Quality Gate passedIssues Measures |
What's new in this PR?
Need an option to get senders name by MessageId.
Of course we could use existed
GetMessageByIdUseCase
and getsender
from it. But this useCase trigger query to a lot of tables, so better to add some small query and UseCase.