Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add getSenderNameByMessageId useCase WPB-11723 #3186

Merged
merged 6 commits into from
Dec 23, 2024

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Dec 17, 2024

StoryWPB-11723 [Android] Playback improvement - 1 - Scroll / Duration / Speed

What's new in this PR?

Need an option to get senders name by MessageId.
Of course we could use existed GetMessageByIdUseCase and get sender from it. But this useCase trigger query to a lot of tables, so better to add some small query and UseCase.

@borichellow borichellow self-assigned this Dec 17, 2024
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Dec 17, 2024
Copy link
Contributor

github-actions bot commented Dec 17, 2024

Test Results

3 366 tests  +6   3 259 ✅ +6   5m 29s ⏱️ -2s
  577 suites +1     107 💤 ±0 
  577 files   +1       0 ❌ ±0 

Results for commit 4c33c81. ± Comparison against base commit 3c69569.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 17, 2024

@datadog-wireapp
Copy link

datadog-wireapp bot commented Dec 17, 2024

Datadog Report

Branch report: feat/add_get_sender_name_by_message_id_use_case
Commit report: 89b2435
Test service: kalium-jvm

✅ 0 Failed, 3259 Passed, 107 Skipped, 1m 1.7s Total Time

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 54.13%. Comparing base (3c69569) to head (4c33c81).

Files with missing lines Patch % Lines
...ire/kalium/logic/data/message/MessageRepository.kt 0.00% 1 Missing ⚠️
...feature/message/GetSenderNameByMessageIdUseCase.kt 90.90% 1 Missing ⚠️
.../wire/kalium/logic/feature/message/MessageScope.kt 0.00% 1 Missing ⚠️
...e/kalium/persistence/dao/message/MessageDAOImpl.kt 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3186      +/-   ##
===========================================
+ Coverage    54.11%   54.13%   +0.01%     
===========================================
  Files         1260     1261       +1     
  Lines        36730    36748      +18     
  Branches      3733     3734       +1     
===========================================
+ Hits         19877    19894      +17     
- Misses       15415    15416       +1     
  Partials      1438     1438              
Files with missing lines Coverage Δ
.../wire/kalium/persistence/dao/message/MessageDAO.kt 100.00% <ø> (ø)
.../wire/kalium/persistence/db/UserDatabaseBuilder.kt 77.84% <100.00%> (+0.12%) ⬆️
...ire/kalium/logic/data/message/MessageRepository.kt 49.40% <0.00%> (-0.20%) ⬇️
...feature/message/GetSenderNameByMessageIdUseCase.kt 90.90% <90.90%> (ø)
.../wire/kalium/logic/feature/message/MessageScope.kt 0.00% <0.00%> (ø)
...e/kalium/persistence/dao/message/MessageDAOImpl.kt 70.67% <75.00%> (+0.06%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c69569...4c33c81. Read the comment docs.

@borichellow borichellow added this pull request to the merge queue Dec 23, 2024
Merged via the queue into develop with commit 3c7855a Dec 23, 2024
23 checks passed
@borichellow borichellow deleted the feat/add_get_sender_name_by_message_id_use_case branch December 23, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. 🚨 Potential breaking changes 👕 size: M type: feature ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants