Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

other: localize some strings for a custom build (WPB-11703) #3534

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Oct 21, 2024

StoryWPB-11703 [Android] “Report a bug” results in an email to Wire Zendesk - need to change this for C builds


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Some texts are not localized

Solutions

Move that to strings.xml file

Needs releases with:

  • GitHub link to other pull request

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine changed the title fix: localize some strings for a custom build (WPB-11703) feat: localize some strings for a custom build (WPB-11703) Oct 21, 2024
@ohassine ohassine changed the title feat: localize some strings for a custom build (WPB-11703) other: localize some strings for a custom build (WPB-11703) Oct 21, 2024
@ohassine ohassine requested review from a team, typfel, borichellow, vitorhugods, mchenani and saleniuk and removed request for a team October 21, 2024 14:20
Copy link
Contributor

Test Results

863 tests   863 ✅  12m 14s ⏱️
119 suites    0 💤
119 files      0 ❌

Results for commit 581c4ad.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@ohassine ohassine enabled auto-merge (squash) October 21, 2024 16:17
Copy link

@ohassine ohassine merged commit 3f60b41 into release/cycle-4.6 Oct 21, 2024
10 of 11 checks passed
@ohassine ohassine deleted the localize-strings branch October 21, 2024 16:38
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants