fix: Location services availability crash #WPB-11304 #3564
Conversation
Test Results863 tests 863 ✅ 12m 4s ⏱️ Results for commit 6057208. ♻️ This comment has been updated with latest results. |
|
|
APKs built during tests are available here. Scroll down to Artifacts! |
| message = "Checking for location services availability failed", | ||
| throwable = e | ||
| ) | ||
| false |
There was a problem hiding this comment.
returning false here will make it seems like location is only disabled when the whole API is missing, maybe returning an Either or an Enum to reflect the state is better for usability, what do you think @m-zagorski
There was a problem hiding this comment.
If we were to display different message for the end users it would make sense to have some kind of enum or something else here, but as long as we're about to rely on what we have currently (ie the message about location not available) it probably doesnt make sense.
echoes-hq
bot
added
the
echoes: unplanned
yamilmedina
changed the title
https://wearezeta.atlassian.net/browse/WPB-11304
What's new in this PR?
Issues
When location services were removed from device - checking for their availability is crashing the application
Solutions
We need to try/catch the error.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.