Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Conversations and Profile Views are reported individually (WPB-14942) #3792

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

fix: Conversations and Profile Views are reported individually (WPB-14942) #3792

wants to merge 10 commits into from
+113 −9

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Jan 9, 2025 •
edited
Loading

BugWPB-14942 [Android] Conversations and Profile Views are reported individually

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Views for conversations are reported to Countly with a unique conversation ID attached to them: Conversation(eed94f9*)
For some screen we report to countly SomeOther with screen name as route: SomeOther(route=other_user_profile_screen)

Solutions

Check if current screen is SomeOther then we send the route otherwise we send class name

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, typfel, sbakhtiarov, MohamadJaara, saleniuk and mathias-niboulies and removed request for a team January 9, 2025 14:30
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 8.00000% with 23 lines in your changes missing coverage. Please review.

Project coverage is 45.80%. Comparing base (f21c93e) to head (10694ae).

Files with missing lines Patch % Lines
...tlin/com/wire/android/util/CurrentScreenManager.kt 8.00% 23 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3792      +/-   ##
===========================================
- Coverage    45.85%   45.80%   -0.05%     
===========================================
  Files          483      483              
  Lines        16510    16528      +18     
  Branches      2779     2787       +8     
===========================================
  Hits          7571     7571              
- Misses        8159     8177      +18     
  Partials       780      780
Files with missing lines Coverage Δ
...tlin/com/wire/android/util/CurrentScreenManager.kt 26.31% <8.00%> (-6.16%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f21c93e...10694ae. Read the comment docs.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Built wire-android-staging-compat-pr-3792.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Built wire-android-dev-debug-pr-3792.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Built wire-android-staging-compat-pr-3792.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Built wire-android-dev-debug-pr-3792.apk is available for download

@ohassine
fix: address comment
d4dfca8
@ohassine
Merge remote-tracking branch 'origin/Conversations-and-Profile-Views-…
d478e6c 
…are-reported-individually' into Conversations-and-Profile-Views-are-reported-individually
@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3792.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3792.apk is available for download

yamilmedina
yamilmedina reviewed Jan 10, 2025
View reviewed changes
Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, left a question/concern and also to add, for this to work we need to remove this flag

wire-android/core/analytics-enabled/src/main/kotlin/com/wire/android/feature/analytics/AnonymousAnalyticsManagerImpl.kt

Line 46 in a59ff2e

internal var VIEW_TRACKING_ENABLED: Boolean = false

app/src/main/kotlin/com/wire/android/util/CurrentScreenManager.kt Outdated Show resolved Hide resolved
@ohassine
Copy link
Member Author

Looking good, left a question/concern and also to add, for this to work we need to remove this flag

wire-android/core/analytics-enabled/src/main/kotlin/com/wire/android/feature/analytics/AnonymousAnalyticsManagerImpl.kt

Line 46 in a59ff2e

internal var VIEW_TRACKING_ENABLED: Boolean = false

Yes, we still don't need it yet.

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3792.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3792.apk is available for download

@ohassine ohassine requested a review from yamilmedina January 10, 2025 17:55
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3792.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3792.apk is available for download

@ohassine ohassine requested a review from MohamadJaara January 13, 2025 09:42
saleniuk
saleniuk reviewed Jan 14, 2025
View reviewed changes
app/src/main/kotlin/com/wire/android/util/CurrentScreenManager.kt
is CurrentScreen.ImportMedia,
is CurrentScreen.DeviceManager -> return@let currentScreen.toScreenName()

else -> return@let (currentScreen as? CurrentScreen.SomeOther)?.route?.getBaseRoute()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: what about AuthRelated type? It will be ignored in this case because else tries to map it to SomeOther

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saleniuk saleniuk saleniuk left review comments

@sbakhtiarov sbakhtiarov sbakhtiarov approved these changes

@typfel typfel Awaiting requested review from typfel typfel was automatically assigned from wireapp/android

@mathias-niboulies mathias-niboulies Awaiting requested review from mathias-niboulies mathias-niboulies was automatically assigned from wireapp/android

@yamilmedina yamilmedina Awaiting requested review from yamilmedina

@MohamadJaara MohamadJaara Awaiting requested review from MohamadJaara

Requested changes must be addressed to merge this pull request.

Assignees

@ohassine ohassine

Labels
echoes/initiative: product-metrics-in-countly Analytics and KPIs size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ohassine @codecov-commenter @sbakhtiarov @yamilmedina @MohamadJaara @saleniuk