-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Conversations and Profile Views are reported individually (WPB-14942) #3792
Open
ohassine
wants to merge
10
commits into
develop
Choose a base branch
from
Conversations-and-Profile-Views-are-reported-individually
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+113
−9
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e3f9399
fix: Conversations and Profile Views are reported individually
ohassine b702518
fix: cleanup
ohassine fc04254
Merge branch 'develop' into Conversations-and-Profile-Views-are-repor…
ohassine 860fd15
fix: disable view tracking
ohassine aa0bce5
Merge remote-tracking branch 'origin/Conversations-and-Profile-Views-…
ohassine 56e2cc2
Merge branch 'develop' into Conversations-and-Profile-Views-are-repor…
ohassine d4dfca8
fix: address comment
ohassine d478e6c
Merge remote-tracking branch 'origin/Conversations-and-Profile-Views-…
ohassine 262e37f
fix: address comment
ohassine 10694ae
fix: use base route
ohassine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
core/analytics-enabled/src/main/kotlin/com/wire/android/feature/analytics/StringExt.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
/* | ||
* Wire | ||
* Copyright (C) 2025 Wire Swiss GmbH | ||
* | ||
* This program is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU General Public License as published by | ||
* the Free Software Foundation, either version 3 of the License, or | ||
* (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU General Public License | ||
* along with this program. If not, see http://www.gnu.org/licenses/. | ||
*/ | ||
package com.wire.android.feature.analytics | ||
|
||
/** | ||
* Converts a snake_case string to camelCase. | ||
*/ | ||
fun String.convertToCamelCase(): String { | ||
return this | ||
.split('_') | ||
.joinToString("") { it.replaceFirstChar { char -> char.uppercase() } } | ||
} |
49 changes: 49 additions & 0 deletions
49
core/analytics-enabled/src/test/kotlin/com/wire/android/feature/analytics/StringExtTest.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
/* | ||
* Wire | ||
* Copyright (C) 2025 Wire Swiss GmbH | ||
* | ||
* This program is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU General Public License as published by | ||
* the Free Software Foundation, either version 3 of the License, or | ||
* (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU General Public License | ||
* along with this program. If not, see http://www.gnu.org/licenses/. | ||
*/ | ||
package com.wire.android.feature.analytics | ||
|
||
import org.junit.Assert.assertEquals | ||
import org.junit.Test | ||
|
||
class StringExtTest { | ||
|
||
@Test | ||
fun `given single word string when converted then return same string`() { | ||
assertEquals("Username", "username".convertToCamelCase()) | ||
} | ||
|
||
@Test | ||
fun `given string with multiple underscores when converted then return camel case string`() { | ||
assertEquals("ThisIsATestCase", ("this_is_a_test_case").convertToCamelCase()) | ||
} | ||
|
||
@Test | ||
fun `given empty string when converted then return empty string`() { | ||
assertEquals("", ("").convertToCamelCase()) | ||
} | ||
|
||
@Test | ||
fun `given string with leading and trailing underscores when converted then return camel case string`() { | ||
assertEquals("LeadingAndTrailing", ("_leading_and_trailing_").convertToCamelCase()) | ||
} | ||
|
||
@Test | ||
fun `given string with numbers when converted then return camel case string`() { | ||
assertEquals("User123Name", ("user_123_name").convertToCamelCase()) | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: what about
AuthRelated
type? It will be ignored in this case becauseelse
tries to map it toSomeOther