-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only coerce scalars if ALLOW_COERCION_OF_SCALARS is enabled #70
Only coerce scalars if ALLOW_COERCION_OF_SCALARS is enabled #70
Conversation
Sounds reasonable; thank you for contributing this fix! One request: would it be possible to add a matching unit test(s)?
and it would be great to check against regression, as Afterburner's handling is quite fragile due to low-level nature of optimization. |
@cowtowncoder do you think this is OK to merge now? |
@dansanduleac Yes, I'd be happy to merge this. Just one more thing: unless I have asked for it (for any Jackson project), we need CLA. It can be found from: https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf and usual way is to print it, fill & sign, scan, email. Normally I'd ask email to As soon as I get that I'll go ahead and merge the patch. Once again thank you for submitting this & apologies for the hassle wrt cla. |
@cowtowncoder not sure if I can add it to a gist, but if you give me some other e-mail address I can send it to, I'd be happy to! |
@dansanduleac Actually |
CLA received, filed, merged the fix. Thank you! This will be in 2.9.9 (and 2.10.0+) |
## Before this PR Ignore file was mentioning the wrong jackson flag - we already use ALLOW_COERCION_OF_SCALARS, but it doesn't work with afterburner. See FasterXML/jackson-modules-base#70 ## After this PR Fixed comments to more accurately describe the ignores that will be fixed by jackson 2.9.9
…burner Only coerce scalars if ALLOW_COERCION_OF_SCALARS is enabled
Fixes #69
This fix is for 2.9, but it should merge without conflicts into 2.10 as well.