Solve compilation issue with NVCC on some PowerPC machines #2702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelReyCG
reviewed
Sep 22, 2023
MelReyCG
reviewed
Sep 22, 2023
sframba
changed the title
MelReyCG
approved these changes
Sep 25, 2023
TotoGaz
approved these changes
Sep 25, 2023
sframba
added
ci: run CUDA builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves issue 2701, at least on the Pangea3 configuration.
The solve involves overriding the
has_const_formattertest for the specific case ofDataContextwith format contextfmt::format_context. This is the smallest override that can solve the issue.There is no risk with this fix, since the
constfomatter is defined in the same file, just above the workaround.If at some point in the future the problem is solved at the
fmtlibrary level, this workaround can be removed at the same time as the library upgrade.If similar issues arise due to
constclasses being passed toGEOS_FMT, the scope of this workaround can be widened accordingly, to encompass the new cases and avoid new compilation issues.