Migrate google_compute_firewall_policy_association resource from DCL to MMv1

[Samir-Cit]

Hello folks.
This PR is to move the Firewall Policy Association (google_compute_firewall_policy_association) resource from DCL to MMv1. And this PR includes:

• Creation of the resource on MMv1.
• Creation of the examples and tests.
• Remove references to DCL resource.

Note: This PR doesn't include the deletion of the DCL resource. This change will be done on the Delarative Resource Client Library repository.

Release Note Template for Downstream PRs (will be copied)

compute: `google_compute_firewall_policy_association` now uses MMv1 engine instead of DCL.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[melinath]

@Samir-Cit I've reassigned this to @slevenick, who is a SME regarding DCL -> MMv1 migrations. He'll be able to take a look the week of 8/19 - please let me know if there's any particular urgency on this (like needing it to get in before the 6.0.0 release for some reason.)

[github-actions]

@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @slevenick This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[c2thorn]

Confirming that I have spoken with @Samir-Cit offline and received permission to force push to this branch

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 93 insertions(+), 260 deletions(-))
google-beta provider: Diff ( 5 files changed, 248 insertions(+), 113 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 79 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Resource google_compute_firewall_policy_association was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 1027
Passed tests: 951
Skipped tests: 74
Affected tests: 2

Click here to see the affected service packages

• compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeFirewallPolicyAssociation_basic
• TestAccComputeFirewallPolicyAssociation_organization

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeFirewallPolicyAssociation_basic[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyAssociation_organization[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 86 insertions(+), 25 deletions(-))
google-beta provider: Diff ( 5 files changed, 271 insertions(+), 137 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 94 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1049
Passed tests: 974
Skipped tests: 73
Affected tests: 2

Click here to see the affected service packages

• compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeFirewallPolicyAssociation_basic
• TestAccComputeFirewallPolicyAssociation_organization

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeFirewallPolicyAssociation_basic [Debug log]
TestAccComputeFirewallPolicyAssociation_organization [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[github-actions]

@GoogleCloudPlatform/terraform-team @melinath This PR has been waiting for review for 12 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[melinath]

It looks like the bot didn't take the time in draft mode into account - opened hashicorp/terraform-provider-google#20142 to track this. It's also now reminding based on the initial assignment message (which was a recent change to how the reminders work) so I've updated that to point to @slevenick as well.