Adding ocean basin in the Metadata

[guillaumevernieres]

What was done

• Reorganization of what's in NetCDFToIodaConverter.h: Moved structs and functions to util.h as an attempt to make the code slightly cleaner
• Added a simple OceanMask struct that reads in regional ocean masks from reccap2 ocean mask. The struct has a method to return the integer mask at a specific location.
• Fixed a bug in trim, related to the optional float metadata
• implementation of the new feature in the RADS converter

Notes

It's currently not part of the CI, something to think about in the future. We could add RECCAP2_region_masks_all_v20221025.nc to the tarball or stage it on hpc somewhere ...

[ShastriPaturi]

Looks fine to me. Didn't run for RADS to test the ocean basins

[guillaumevernieres]

Tested with more obs:

[emcbot]

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Wed Nov 15 22:33:26 UTC 2023 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Nov 15 23:17:46 UTC 2023
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Wed Nov 15 23:56:02 UTC 2023
Tests: 79% tests passed, 11 tests failed out of 53
	1584 - test_gdasapp_convert_bufr_temp_dbuoy (Failed)
	1585 - test_gdasapp_convert_bufr_salt_dbuoy (Failed)
	1586 - test_gdasapp_convert_bufr_temp_mbuoyb (Failed)
	1587 - test_gdasapp_convert_bufr_salt_mbuoyb (Failed)
	1588 - test_gdasapp_convert_bufr_tesacprof (Failed)
	1589 - test_gdasapp_convert_bufr_trkobprof (Failed)
	1590 - test_gdasapp_convert_bufr_sfcships (Failed)
	1591 - test_gdasapp_convert_bufr_sfcshipsu (Failed)
	1606 - test_gdasapp_soca_incr_handler (Failed)
	1612 - test_gdasapp_convert_bufr_adpsfc_snow (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/732/global-workflow/sorc/gdas.cd/build/log.ctest

[emcbot]

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Wed Nov 15 16:31:21 CST 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Nov 15 17:40:53 CST 2023
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Wed Nov 15 18:43:33 CST 2023
Tests: 79% tests passed, 11 tests failed out of 53
	1584 - test_gdasapp_convert_bufr_temp_dbuoy (Failed)
	1585 - test_gdasapp_convert_bufr_salt_dbuoy (Failed)
	1586 - test_gdasapp_convert_bufr_temp_mbuoyb (Failed)
	1587 - test_gdasapp_convert_bufr_salt_mbuoyb (Failed)
	1588 - test_gdasapp_convert_bufr_tesacprof (Failed)
	1589 - test_gdasapp_convert_bufr_trkobprof (Failed)
	1590 - test_gdasapp_convert_bufr_sfcships (Failed)
	1591 - test_gdasapp_convert_bufr_sfcshipsu (Failed)
	1606 - test_gdasapp_soca_incr_handler (Failed)
	1612 - test_gdasapp_convert_bufr_adpsfc_snow (Failed)
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/732/global-workflow/sorc/gdas.cd/build/log.ctest

[guillaumevernieres]

Well ... That's a new one

1606 - test_gdasapp_soca_incr_handler (Failed)

[AndrewEichmann-NOAA]

nothing obviously wrong

[AndrewEichmann-NOAA]

Tested with more obs:

What's zero/red? Continental shelf?

[guillaumevernieres]

Tested with more obs:

What's zero/red? Continental shelf?

Yes @AndrewEichmann-NOAA . I wonder if we should make sure we don't flag land ... Humm ...