Upgrade to ROS2 Iron #375
Merged
Upgrade to ROS2 Iron #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rosbag2 submodule is removed here as the desired functionality is included in humble.
hdefazio
reviewed
Dec 4, 2023
…to experiment/upgrade-to-iron * origin/experiment/upgrade-to-humble: Experimental upgrade to the next LTS version Humble Hawksbill Removed poetry lock due to large amount of conflicts. Will need to regenerate.
There are ROS workspace build issues to resolve next.
Purg
force-pushed
the
experiment/upgrade-to-iron
branch
from
32f4b8c to
72fc82c
Compare
|
For whatever reason, the calling things like |
Purg
force-pushed
the
experiment/upgrade-to-iron
branch
from
0e4fe70 to
0b0de78
Compare
|
@hdefazio I believe I am done with this upgrade. The system runs to completion as expected and lingering issues or upgrades have been resolved. If you don't think you have time for a review, let me know so I can get this into main. |
Some logging functions changed behavior a little.
Fix references to Simple2dDetectionOverlay which is now in angel_utils.
Fix yolo object detection node to declare a dynamic cuda_device_id parameter to accept numbers and "cpu" string.
3.10.12 is the version installed inside the container. The hope here is that by collapsing the version compatibility range, we will not see any subtle bugs due to using a different minor version of python. This also opens up the ability to use any python features introduced up to and including 3.10.
Purg
force-pushed
the
experiment/upgrade-to-iron
branch
3 times, most recently
from
9546559 to
940e62f
Compare
* Add rosdep update call if that has not occurred yet in the current workspace. * Remove old TTY restriction from build script, use-case invalid.
Purg
force-pushed
the
experiment/upgrade-to-iron
branch
from
940e62f to
5e50753
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is currently based on #374.
I have locally verified the container environment build and will successfully process the
all_activities_20/bag file to completion, producing valid object detection, activity classification and task update messages as visualized in the engineering UI.Things that are now a little weird:
ros2 ...likeros2 topic listresults in a stack-track involvingConnectionResetError: [Errno 104] Connection reset by peer. This seems to not happen when not using--net hostin docker, but does happen when we use--net host(what we have been doing).