Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone launch file for rviz #161

Merged
merged 9 commits into from
Nov 16, 2023
Merged

Standalone launch file for rviz #161

merged 9 commits into from
Nov 16, 2023

Conversation

jbarry-bdai
Copy link
Collaborator

This creates a standalone launch file that can be used to launch rviz so it doesn't always have to happen in the driver.

It also removes point clouds and images from the default rviz that's launched - currently it's just the robot model and TF. That can be changed if people preferred it a different way.

This is based off @jschornak-bdai 's pointcloud publishing branch to avoid conflicts (and also cuz that's when I wanted it).

ksharma-bdai
ksharma-bdai previously approved these changes Oct 16, 2023
mpickett-bdai
mpickett-bdai previously approved these changes Oct 16, 2023
Copy link
Collaborator

@mpickett-bdai mpickett-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree Andrew's suggestion, but besides that looks good to go.

Base automatically changed from jschornak/PN-90-publish-point-clouds to main October 19, 2023 18:40
@jschornak-bdai jschornak-bdai dismissed stale reviews from mpickett-bdai and ksharma-bdai October 19, 2023 18:40

The base branch was changed.

@jschornak-bdai
Copy link
Contributor

We merged #147, so this can be updated onto the latest state of main.

@jbarry-bdai
Copy link
Collaborator Author

Oh yeah I just need to update and test this. I'll get to it this week unless someone else wants to do that sooner :-p

@bhung-bdai
Copy link
Collaborator

Oh yeah I just need to update and test this. I'll get to it this week unless someone else wants to do that sooner :-p

Oh yeah I just need to update and test this. I'll get to it this week unless someone else wants to do that sooner :-p

I can probably take a crack at it tomorrow. Is there anything specific I need to do, other than use the new arguments/config parameters for DepthRegistered?

Copy link
Collaborator

@bhung-bdai bhung-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on hardware and it's much easier to pull up than before. Wondering if we can set the QoS automagically, but if we can't we should update the README on how to visualize the point clouds somewhere.

@@ -0,0 +1,82 @@
# Copyright [2023] Boston Dynamics AI Institute, Inc.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Quality of Service needs to be set to "best effort" in Rviz if you want to visualize the PointCloud2 under Reliability Policy. Is there a way to set that automatically in this config?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a way to have that default to the right setting, but I think you need to provide that in the config YAML file. Here's the full entry for a PointCloud display, for example. We set Topic -> Reliability Policy to Best Effort instead of Reliable.

    - Alpha: 1
      Autocompute Intensity Bounds: true
      Autocompute Value Bounds:
        Max Value: 3.0432052612304688
        Min Value: -0.07985210418701172
        Value: true
      Axis: Z
      Channel Name: intensity
      Class: rviz_default_plugins/PointCloud2
      Color: 255; 255; 255
      Color Transformer: AxisColor
      Decay Time: 0
      Enabled: true
      Invert Rainbow: false
      Max Color: 255; 255; 255
      Max Intensity: 4096
      Min Color: 0; 0; 0
      Min Intensity: 0
      Name: PointCloud2
      Position Transformer: XYZ
      Selectable: true
      Size (Pixels): 3
      Size (m): 0.009999999776482582
      Style: Flat Squares
      Topic:
        Depth: 5
        Durability Policy: Volatile
        History Policy: Keep Last
        Reliability Policy: Best Effort
        Value: /points_back
      Use Fixed Frame: true
      Use rainbow: true
      Value: true

Copy link
Collaborator

@bhung-bdai bhung-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HIL tested and passed

@amessing-bdai amessing-bdai merged commit 54d9442 into main Nov 16, 2023
@amessing-bdai amessing-bdai deleted the jlb/rviz_launch branch November 16, 2023 17:55
marlow-fawn pushed a commit to marlow-fawn/spot_ros2 that referenced this pull request Aug 19, 2024
Co-authored-by: Joe Schornak <[email protected]>
Co-authored-by: Andrew Messing <[email protected]>
Co-authored-by: Anthony Baker <[email protected]>
Co-authored-by: Anthony Baker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants